feat: modify txmgr to send EIP-1559 txns#2086
Merged
mslipper merged 6 commits intoethereum-optimism:developfrom Jan 31, 2022
Merged
feat: modify txmgr to send EIP-1559 txns#2086mslipper merged 6 commits intoethereum-optimism:developfrom
mslipper merged 6 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 3a7e709 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6c860d7 to
e7d25e2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2086 +/- ##
========================================
Coverage 75.37% 75.37%
========================================
Files 81 81
Lines 2705 2705
Branches 436 436
========================================
Hits 2039 2039
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
e7d25e2 to
c812161
Compare
mslipper
approved these changes
Jan 28, 2022
c999a67 to
52c5bd7
Compare
cfromknecht
commented
Jan 28, 2022
Contributor
Author
There was a problem hiding this comment.
@tynes is the best we can do in terms of a fallback? i.e. using a constant, or is there a better way you can think of?
This commit adds a fallback in case the L1 provider does not support queries for eth_maxPriorityFeePerGas. Of our infrastructure providers, i.e. Alchemy, Infura, Quicknode, and Hardhat (in test envs), only Alchemy suports this call. In production, we will be routing this call directly to Alchemy, which should work in the general case. However, if they were to be unavailable the batch submitter would be stalled until service was restored. This modification also allows the new EIP-1559 batch submitter to pass our integration tests, since the default Hardhat backend can't support the query either.
Removes the MAX_L1_GAS_PRICE_IN_GWEI and GAS_RETRY_INCREMENT env vars, as well as the MinL1GasPrice, MaxL1GasPrice, and GasRetryIncrement values from the txmgr config struct.
6169fed to
5cdc950
Compare
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
…`derivationOriginUpdate` (#2331) Closes #2086 The PR: - Introduces new table `BlockTraversal` to store all L1 blocks, even if there are no L2 blocks derived from it. - Add respective trait methods. - Modified `latest_derived_block_pair` to send the latest derived block from `DerivedBlocks` and latest source block from `BlockTraversal`. - Exclusively dealing with `derivationUpdate` and `derivationOriginUpdate` i.e. updating latest derived on `derivationUpdate` and updating latest source on `derivationOriginUpdate`. - The e2e test `TestFinalizedHeadAdvancing` passes now. TODO: (in another PR) - Remove `current_l1` and its usage. No longer required. - ~~For now, `check_node_consistency()` is commented in this PR. #2330 takes care of that.~~ ~~Currently in draft: Tests are missing.~~ --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
…`derivationOriginUpdate` (op-rs/kona#2331) Closes #2086 The PR: - Introduces new table `BlockTraversal` to store all L1 blocks, even if there are no L2 blocks derived from it. - Add respective trait methods. - Modified `latest_derived_block_pair` to send the latest derived block from `DerivedBlocks` and latest source block from `BlockTraversal`. - Exclusively dealing with `derivationUpdate` and `derivationOriginUpdate` i.e. updating latest derived on `derivationUpdate` and updating latest source on `derivationOriginUpdate`. - The e2e test `TestFinalizedHeadAdvancing` passes now. TODO: (in another PR) - Remove `current_l1` and its usage. No longer required. - ~~For now, `check_node_consistency()` is commented in this PR. #2330 takes care of that.~~ ~~Currently in draft: Tests are missing.~~ --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modifies the
txmgrto use EIP-1559 dynamic fee txns, rather the currentmethod of linearly increasing the gas price between a configured minimum
and maximum.
In addition, we add generic fallback in case the L1 provider does not support
queries for
eth_maxPriorityFeePerGas. Of our infrastructure providers,i.e. Alchemy, Infura, Quicknode, and Hardhat (in test envs), only
Alchemy supports this call. In production, we will be routing this call
directly to Alchemy, which should work in the general case. However, if
they were to be unavailable the batch submitter would be stalled until
service was restored. This modification also allows the new EIP-1559
batch submitter to pass our integration tests, since the default Hardhat
backend doesn't support the query either.
Compare to the existing, approach, we should see quicker confirmation times,
as the prior iteration would start ratcheting from well below the market rate. This
should have small, net positive effect on the overall TPS of the system.
Metadata