fix(sdk): comment out getMessagesByAddress#2330
Conversation
Removes getMessagesByAddress from the SDK until we can get the function to work properly. Likely requires the indexer to be integrated into the SDK or to figure out some new way to quickly get all of the data we need. Better to comment this out to avoid confusion.
🦋 Changeset detectedLatest commit: d49feca The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2330 +/- ##
===========================================
+ Coverage 80.08% 80.14% +0.06%
===========================================
Files 77 77
Lines 2460 2458 -2
Branches 450 450
===========================================
Hits 1970 1970
+ Misses 490 488 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I think you should delete it or make it private instead of commenting it out |
Do you have a strong preference on this? I don't think it makes a huge difference and at least it shows that we intend to add the code later for anyone reading the source. |
No strong opinions here |
This PR refactors the managed node modules and fix consistency check issues Closes #2329
…`derivationOriginUpdate` (#2331) Closes #2086 The PR: - Introduces new table `BlockTraversal` to store all L1 blocks, even if there are no L2 blocks derived from it. - Add respective trait methods. - Modified `latest_derived_block_pair` to send the latest derived block from `DerivedBlocks` and latest source block from `BlockTraversal`. - Exclusively dealing with `derivationUpdate` and `derivationOriginUpdate` i.e. updating latest derived on `derivationUpdate` and updating latest source on `derivationOriginUpdate`. - The e2e test `TestFinalizedHeadAdvancing` passes now. TODO: (in another PR) - Remove `current_l1` and its usage. No longer required. - ~~For now, `check_node_consistency()` is commented in this PR. #2330 takes care of that.~~ ~~Currently in draft: Tests are missing.~~ --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
…`derivationOriginUpdate` (op-rs/kona#2331) Closes #2086 The PR: - Introduces new table `BlockTraversal` to store all L1 blocks, even if there are no L2 blocks derived from it. - Add respective trait methods. - Modified `latest_derived_block_pair` to send the latest derived block from `DerivedBlocks` and latest source block from `BlockTraversal`. - Exclusively dealing with `derivationUpdate` and `derivationOriginUpdate` i.e. updating latest derived on `derivationUpdate` and updating latest source on `derivationOriginUpdate`. - The e2e test `TestFinalizedHeadAdvancing` passes now. TODO: (in another PR) - Remove `current_l1` and its usage. No longer required. - ~~For now, `check_node_consistency()` is commented in this PR. #2330 takes care of that.~~ ~~Currently in draft: Tests are missing.~~ --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Description
Removes getMessagesByAddress from the SDK until we can get the function
to work properly. Likely requires the indexer to be integrated into the
SDK or to figure out some new way to quickly get all of the data we
need. Better to comment this out to avoid confusion.