Skip to content

Preventing ovmCREATE and ovmCREATE2 Collisions#230

Closed
ben-chain wants to merge 5 commits intomasterfrom
bug/YAS459/prevent-ovmCREATE2-overwrites
Closed

Preventing ovmCREATE and ovmCREATE2 Collisions#230
ben-chain wants to merge 5 commits intomasterfrom
bug/YAS459/prevent-ovmCREATE2-overwrites

Conversation

@ben-chain
Copy link
Copy Markdown
Collaborator

@ben-chain ben-chain commented Aug 25, 2020

Description

This little PR prevents ovmCREATE2 from succeeding if the given salt has previously been successfully used by the contract.

Questions

N/A

Metadata

Fixes

  • Fixes YAS 459

Contributing Agreement

@ben-chain
Copy link
Copy Markdown
Collaborator Author

Whoops, realized this check will apply to CREATE as well with the addition of ovmSetNonce opcode. Updating!

@ben-chain ben-chain changed the title Preventing ovmCREATE2 Overwrites Preventing ovmCREATE and ovmCREATE2 Collisions Aug 26, 2020
@ben-chain
Copy link
Copy Markdown
Collaborator Author

Update: since the StateTransitioner does not yet expose proveContractExclusion, we can't get this working in fraud proofs quite yet. Holding off any merge till we resolve.

@ben-chain ben-chain closed this Aug 27, 2020
@gakonst gakonst deleted the bug/YAS459/prevent-ovmCREATE2-overwrites branch March 18, 2021 15:02
Inphi pushed a commit that referenced this pull request Aug 16, 2024
Updates MIPSInstructions so that it correctly reverts on calls to
add, addi, and sub that overflow/underflow. Additionally includes
tests that demonstrates that the unchecked versions of the same
opcodes allow for overflow/underflow.
Inphi pushed a commit that referenced this pull request Aug 16, 2024
…279)

This reverts commit 864e59a821e87f9dd00ae97f85add93fa3857597.
samlaf pushed a commit to samlaf/optimism that referenced this pull request Aug 20, 2024
…m#230)

Updates MIPSInstructions so that it correctly reverts on calls to
add, addi, and sub that overflow/underflow. Additionally includes
tests that demonstrates that the unchecked versions of the same
opcodes allow for overflow/underflow.
samlaf pushed a commit to samlaf/optimism that referenced this pull request Aug 20, 2024
theochap pushed a commit that referenced this pull request Dec 10, 2025
* feat(kona-derive): pipeline output validation

* fix(kona-derive): pipeline interface and associated builder:

* fixes

* Update crates/derive/src/online/validation.rs

Co-authored-by: clabby <ben@clab.by>

---------

Co-authored-by: clabby <ben@clab.by>
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
### Description

Consolidates links into the `links.md` doc.
emhane pushed a commit that referenced this pull request Feb 3, 2026
Based on #229

Adds tests to ensure that storing TrieUpdates that include deletions
actually deletes the nodes at that block height, and that updates take
precedence over deletions (same as `write_trie_updates` in Reth).

Closes #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant