Update Buidler OVM node plugin to work within tasks#238
Merged
Conversation
willmeister
approved these changes
Aug 28, 2020
karlfloersch
approved these changes
Aug 28, 2020
Contributor
karlfloersch
left a comment
There was a problem hiding this comment.
This looks good to me! I confess I'm not super familiar with these buidler APIs but all of the changes seem pretty straight forward
| }, | ||
| solc: { | ||
| path: path.resolve(__dirname, '../../node_modules/@eth-optimism/solc'), | ||
| version: '0.5.16', |
Contributor
There was a problem hiding this comment.
What does this change do?
Contributor
Author
There was a problem hiding this comment.
Made it so that it uses the normal compiler by default, doesn't use the OVM unless the --ovm flag is set.
Contributor
There was a problem hiding this comment.
Ahh ok makes sense, cool!
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* add function * cleaning * fix revert prefixing and add test revertmsg * write SM * debug: progress * Remove unnecessary logs * Fix typo Typo Co-authored-by: ben-chain <ben@pseudonym.party> * Update contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Ben Jones <ben@pseudonym.party> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
Inphi
pushed a commit
that referenced
this pull request
Aug 16, 2024
Existing step logic wrote the register offset into memory but the compiler should already be doing this when the struct is defined. Instead of writing directly into memory, this change verifies that the memory at that location has the expected value which will catch any cases where the compiler's memory allocation mechanism changes in the future.
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Aug 20, 2024
…eum-optimism#238) Existing step logic wrote the register offset into memory but the compiler should already be doing this when the struct is defined. Instead of writing directly into memory, this change verifies that the memory at that location has the expected value which will catch any cases where the compiler's memory allocation mechanism changes in the future.
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 1, 2025
The code already exists on Alfajores and matches the one that would be deployed, therefore we just allow this address.
QuentinI
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 7, 2025
The code already exists on Alfajores and matches the one that would be deployed, therefore we just allow this address.
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4. - [Release notes](https://github.com/peaceiris/actions-gh-pages/releases) - [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md) - [Commits](peaceiris/actions-gh-pages@v3...v4) --- updated-dependencies: - dependency-name: peaceiris/actions-gh-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the buidler ovm node plugin to expose a function
startOvmNodethat can be called within a task based on anovmflag. This is needed for how Synthetix has their Buidler config set up.Questions
None
Metadata
Fixes
Contributing Agreement