Skip to content

Set signer.provider to OptimismProvider#279

Merged
K-Ho merged 1 commit intomasterfrom
fix/Synthetix/OptimismSignerNaming
Sep 23, 2020
Merged

Set signer.provider to OptimismProvider#279
K-Ho merged 1 commit intomasterfrom
fix/Synthetix/OptimismSignerNaming

Conversation

@K-Ho
Copy link
Copy Markdown
Contributor

@K-Ho K-Ho commented Sep 23, 2020

Description

Previously our OptimismSigner's provider was the Web3Provider (from metamask) and optimism was set to the OptimismProvider. This leads to issues where signer.provider is used by default. This PR changes signer.provider to be the OptimismProvider and adds signer.web3 which is the Web3Provider (from metamask)

Metadata

Fixes

  • Fixes #

Contributing Agreement

Copy link
Copy Markdown
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@K-Ho K-Ho merged commit b59d01d into master Sep 23, 2020
@K-Ho K-Ho deleted the fix/Synthetix/OptimismSignerNaming branch September 23, 2020 03:27
snario pushed a commit that referenced this pull request Apr 14, 2021
* Use dev package

* Add chai and mocha back in

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
sebastianst added a commit that referenced this pull request Feb 13, 2023
sebastianst added a commit that referenced this pull request Feb 14, 2023
Inphi pushed a commit that referenced this pull request Aug 16, 2024
…279)

This reverts commit 864e59a821e87f9dd00ae97f85add93fa3857597.
samlaf pushed a commit to samlaf/optimism that referenced this pull request Aug 20, 2024
theochap pushed a commit that referenced this pull request Dec 10, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
### Description

Adds an example to the `op-alloy` book that walks through implementing
`L1BlockInfo` hardfork changes in `op-alloy`.

Closes #279
theochap pushed a commit that referenced this pull request Jan 21, 2026
### Description

Adds an example to the `op-alloy` book that walks through implementing
`L1BlockInfo` hardfork changes in `op-alloy`.

Closes #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants