Skip to content

Revert "op-node/p2p: ensure all topics are added to the topic scoring map"#15419

Merged
sebastianst merged 1 commit intodevelopfrom
revert-15314-gk/15297
Apr 15, 2025
Merged

Revert "op-node/p2p: ensure all topics are added to the topic scoring map"#15419
sebastianst merged 1 commit intodevelopfrom
revert-15314-gk/15297

Conversation

@sebastianst
Copy link
Copy Markdown
Member

Reverts #15314

It causes serious peering issues in its current form. Need to investigate a proper fix first.

@sebastianst sebastianst requested review from a team as code owners April 15, 2025 18:40
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.35%. Comparing base (0737b13) to head (48c949f).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15419      +/-   ##
===========================================
- Coverage    46.43%   45.35%   -1.08%     
===========================================
  Files         1252     1193      -59     
  Lines       104065    99341    -4724     
===========================================
- Hits         48319    45058    -3261     
+ Misses       52322    51035    -1287     
+ Partials      3424     3248     -176     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/p2p/gossip.go 53.22% <100.00%> (-0.29%) ⬇️
op-node/p2p/peer_params.go 91.66% <100.00%> (-0.65%) ⬇️

... and 67 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastianst sebastianst added this pull request to the merge queue Apr 15, 2025
Merged via the queue into develop with commit c8b9f62 Apr 15, 2025
49 checks passed
@sebastianst sebastianst deleted the revert-15314-gk/15297 branch April 15, 2025 19:27
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request May 13, 2025
iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants