Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15314 +/- ##
============================================
+ Coverage 46.32% 86.89% +40.56%
============================================
Files 1227 117 -1110
Lines 102944 6081 -96863
============================================
- Hits 47691 5284 -42407
+ Misses 51892 771 -51121
+ Partials 3361 26 -3335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
refcell
reviewed
Apr 11, 2025
refcell
approved these changes
Apr 11, 2025
Contributor
refcell
left a comment
There was a problem hiding this comment.
This looks the desired logic to me. Topic score params can be tuned on a per-topic basis as needed in the future. 👍
protolambda
approved these changes
Apr 11, 2025
ClaytonNorthey92
pushed a commit
to hemilabs/optimism
that referenced
this pull request
May 13, 2025
…hereum-optimism#15314) * introduce allBlocksTopics helper * modify test to assert all block topics are present currently failing * add all block topics to map * spacing
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
…hereum-optimism#15314) * introduce allBlocksTopics helper * modify test to assert all block topics are present currently failing * add all block topics to map * spacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15297