Add genproto version excludes to optimism to resolve conflict dependencies#1
Merged
max-sanchez merged 2 commits intohemifrom Apr 16, 2024
Merged
Add genproto version excludes to optimism to resolve conflict dependencies#1max-sanchez merged 2 commits intohemifrom
max-sanchez merged 2 commits intohemifrom
Conversation
ClaytonNorthey92
approved these changes
Apr 16, 2024
joshuasing
reviewed
Apr 16, 2024
joshuasing
approved these changes
Apr 16, 2024
ClaytonNorthey92
pushed a commit
that referenced
this pull request
May 8, 2025
… map (#1…" (ethereum-optimism#15419) This reverts commit 9a92fed.
ClaytonNorthey92
pushed a commit
that referenced
this pull request
May 13, 2025
… map (#1…" (ethereum-optimism#15419) This reverts commit 9a92fed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies of optimism and op-geth use various conflicting versions of genproto, so exclude specific versions that dependencies rely on to force use of one version of genproto and let all repos compile correctly.