Envoy Update to d3110f4 (May 9, 2022)#847
Merged
mum4k merged 9 commits intoenvoyproxy:mainfrom May 11, 2022
Merged
Conversation
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
…1 DSA. To achieve the same result as the previous test, we need nighthawk to have certs for both encryptions. Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
…sense. Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
mum4k
approved these changes
May 11, 2022
Collaborator
mum4k
left a comment
There was a problem hiding this comment.
Only two minor comments, otherwise we're good to go.
Collaborator
|
Going to merge in as is, we can address the minor comments in a follow-up. |
This was referenced May 11, 2022
mum4k
pushed a commit
that referenced
this pull request
May 12, 2022
Fixes #849. Re-enable Clang Tidy CI target. run-clang-tidy changed locations in LLVM 13.01 (https://releases.llvm.org/13.0.1/tools/clang/tools/extra/docs/ReleaseNotes.html#improvements-to-clang-tidy). This broke the target when we upgraded to 14.0.0 in #847 The upgrade also caused several new linter warnings. - disabled bugprone-easily-swappable-parameters as it is non-trivial to fix. - fixed all modernize-return-braced-init-list warnings - fixed all modernize-use-default-member-init warnings Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
mum4k
pushed a commit
that referenced
this pull request
May 12, 2022
Addressing outstanding comments in #847 Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-tidyCI step until do_ci.sh clang_tidy CI target fails #849 gets resolved.Signed-off-by: tomjzzhang 4367421+tomjzzhang@users.noreply.github.com