Skip to content

Fix Clang Tidy CI Target#850

Merged
mum4k merged 14 commits intoenvoyproxy:mainfrom
tomjzzhang:clang_tidy_testing
May 12, 2022
Merged

Fix Clang Tidy CI Target#850
mum4k merged 14 commits intoenvoyproxy:mainfrom
tomjzzhang:clang_tidy_testing

Conversation

@tomjzzhang
Copy link
Copy Markdown
Contributor

@tomjzzhang tomjzzhang commented May 10, 2022

Fixes #849. Re-enable Clang Tidy CI target.

run-clang-tidy changed locations in LLVM 13.01 (https://releases.llvm.org/13.0.1/tools/clang/tools/extra/docs/ReleaseNotes.html#improvements-to-clang-tidy). This broke the target when we upgraded to 14.0.0 in #847

The upgrade also caused several new linter warnings.

  • disabled bugprone-easily-swappable-parameters as it is non-trivial to fix.
  • fixed all modernize-return-braced-init-list warnings
  • fixed all modernize-use-default-member-init warnings

Signed-off-by: tomjzzhang 4367421+tomjzzhang@users.noreply.github.com

Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
@mum4k mum4k marked this pull request as draft May 11, 2022 00:34
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
@tomjzzhang tomjzzhang changed the title Disable all pipelines except for clang_tidy and dependencies Fix Clang Tidy CI Target May 11, 2022
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
@tomjzzhang tomjzzhang marked this pull request as ready for review May 11, 2022 22:39
@tomjzzhang tomjzzhang added the waiting-for-review A PR waiting for a review. label May 11, 2022
@mum4k mum4k merged commit 38cf865 into envoyproxy:main May 12, 2022
@tomjzzhang tomjzzhang deleted the clang_tidy_testing branch May 17, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

do_ci.sh clang_tidy CI target fails

2 participants