Skip to content

feat: downstream mTLS#2490

Merged
arkodg merged 7 commits intoenvoyproxy:mainfrom
arkodg:implement-mtls
Feb 14, 2024
Merged

feat: downstream mTLS#2490
arkodg merged 7 commits intoenvoyproxy:mainfrom
arkodg:implement-mtls

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Jan 23, 2024

Relates to #2483

@arkodg arkodg requested a review from a team as a code owner January 23, 2024 22:09
@arkodg arkodg marked this pull request as draft January 23, 2024 22:09
@arkodg arkodg mentioned this pull request Jan 23, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 224 lines in your changes are missing coverage. Please review.

Comparison is base (446997b) 63.89% compared to head (1056fb6) 63.57%.

❗ Current head 1056fb6 differs from pull request most recent head 23fe1c8. Consider uploading reports for the commit 23fe1c8 to get more accurate results

Files Patch % Lines
internal/provider/kubernetes/controller.go 22.52% 83 Missing and 3 partials ⚠️
internal/provider/kubernetes/indexers.go 5.00% 36 Missing and 2 partials ⚠️
internal/gatewayapi/clienttrafficpolicy.go 66.66% 15 Missing and 5 partials ⚠️
internal/gatewayapi/validate.go 58.33% 14 Missing and 6 partials ⚠️
internal/ir/zz_generated.deepcopy.go 0.00% 18 Missing and 1 partial ⚠️
internal/provider/kubernetes/predicates.go 58.06% 10 Missing and 3 partials ⚠️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% 9 Missing ⚠️
internal/xds/translator/listener.go 70.00% 8 Missing and 1 partial ⚠️
internal/xds/translator/translator.go 33.33% 6 Missing and 2 partials ⚠️
internal/gatewayapi/resource.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
- Coverage   63.89%   63.57%   -0.33%     
==========================================
  Files         119      119              
  Lines       18847    18944      +97     
==========================================
+ Hits        12042    12043       +1     
- Misses       6010     6097      +87     
- Partials      795      804       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg force-pushed the implement-mtls branch 2 times, most recently from 6946ed4 to 896c97a Compare January 30, 2024 23:24
Arko Dasgupta added 2 commits February 9, 2024 14:12
Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Arko Dasgupta added 3 commits February 9, 2024 19:57
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg marked this pull request as ready for review February 10, 2024 04:40
@arkodg arkodg requested a review from a team February 10, 2024 04:40
@arkodg arkodg requested a review from guydc February 12, 2024 19:31
@arkodg arkodg mentioned this pull request Feb 12, 2024
@arkodg arkodg merged commit 765903a into envoyproxy:main Feb 14, 2024
@arkodg arkodg deleted the implement-mtls branch February 14, 2024 01:46
yaelSchechter pushed a commit to yaelSchechter/envoy-gateway that referenced this pull request Feb 14, 2024
* feat: downstream mTLS

Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* configmap provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
arkodg pushed a commit that referenced this pull request Feb 14, 2024
fix mtls failed test

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zirain added a commit that referenced this pull request Feb 18, 2024
* feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default (#2585)

* Implement and update tests for the default header transformations.

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Make 'gen-check' happy

Signed-off-by: Lior Okman <lior.okman@sap.com>

---------

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* bug: fix merge race (#2604)

Between #2585
&
#2581

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* feat: downstream mTLS (#2490)

* feat: downstream mTLS

Relates to #2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* configmap provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add timeout to clientTrafficPolicy

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add omitempty

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add cel test for coverage

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* run make commands

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* change request timeout field name and desc

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* tidy up comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix cel test

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix typo

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* run generate

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

---------

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: Lior Okman <lior.okman@sap.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants