Skip to content

chore: fix failed test case introduced by #2490#2608

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
shawnh2:fix-broken-ci
Feb 14, 2024
Merged

chore: fix failed test case introduced by #2490#2608
arkodg merged 1 commit intoenvoyproxy:mainfrom
shawnh2:fix-broken-ci

Conversation

@shawnh2
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 commented Feb 14, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2490 test case

@shawnh2
fix mtls failed test
e92561a 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner February 14, 2024 14:25
@shawnh2 shawnh2 mentioned this pull request Feb 14, 2024
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 224 lines in your changes are missing coverage. Please review.

Comparison is base (446997b) 63.89% compared to head (e92561a) 63.38%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/provider/kubernetes/controller.go 22.52% 83 Missing and 3 partials ⚠️
internal/provider/kubernetes/indexers.go 5.00% 36 Missing and 2 partials ⚠️
internal/gatewayapi/clienttrafficpolicy.go 66.66% 15 Missing and 5 partials ⚠️
internal/gatewayapi/validate.go 58.33% 14 Missing and 6 partials ⚠️
internal/ir/zz_generated.deepcopy.go 0.00% 18 Missing and 1 partial ⚠️
internal/provider/kubernetes/predicates.go 58.06% 10 Missing and 3 partials ⚠️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% 9 Missing ⚠️
internal/xds/translator/listener.go 70.00% 8 Missing and 1 partial ⚠️
internal/xds/translator/translator.go 33.33% 6 Missing and 2 partials ⚠️
internal/gatewayapi/resource.go 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2608      +/-   ##
==========================================
- Coverage   63.89%   63.38%   -0.51%     
==========================================
  Files         119      119              
  Lines       18847    19163     +316     
==========================================
+ Hits        12042    12147     +105     
- Misses       6010     6200     +190     
- Partials      795      816      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg merged commit b97e5ab into envoyproxy:main Feb 14, 2024
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Feb 14, 2024

thanks @shawnh2 for taking care of this, I should have rebased

@shawnh2 shawnh2 deleted the fix-broken-ci branch February 15, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes

@cnvergence cnvergence cnvergence approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shawnh2 @arkodg @cnvergence