feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default#2585
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom Feb 13, 2024
Merged
Conversation
Signed-off-by: Lior Okman <lior.okman@sap.com>
bd53b2c to
38650e5
Compare
Signed-off-by: Lior Okman <lior.okman@sap.com>
38650e5 to
34852de
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
==========================================
- Coverage 64.09% 64.08% -0.02%
==========================================
Files 119 119
Lines 18628 18647 +19
==========================================
+ Hits 11939 11949 +10
- Misses 5906 5915 +9
Partials 783 783 ☔ View full report in Codecov by Sentry. |
arkodg
pushed a commit
to arkodg/gateway
that referenced
this pull request
Feb 13, 2024
Between envoyproxy#2585 & envoyproxy#2581 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Merged
arkodg
added a commit
that referenced
this pull request
Feb 13, 2024
yaelSchechter
pushed a commit
to yaelSchechter/envoy-gateway
that referenced
this pull request
Feb 14, 2024
…r' header by default (envoyproxy#2585) * Implement and update tests for the default header transformations. Signed-off-by: Lior Okman <lior.okman@sap.com> * Make 'gen-check' happy Signed-off-by: Lior Okman <lior.okman@sap.com> --------- Signed-off-by: Lior Okman <lior.okman@sap.com> Signed-off-by: Yael Shechter <yael.shechter@sap.com>
yaelSchechter
pushed a commit
to yaelSchechter/envoy-gateway
that referenced
this pull request
Feb 14, 2024
Between envoyproxy#2585 & envoyproxy#2581 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Yael Shechter <yael.shechter@sap.com>
arkodg
pushed a commit
to arkodg/gateway
that referenced
this pull request
Feb 16, 2024
Between envoyproxy#2566 & envoyproxy#2585 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Merged
arkodg
added a commit
that referenced
this pull request
Feb 16, 2024
zirain
added a commit
that referenced
this pull request
Feb 18, 2024
* feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default (#2585) * Implement and update tests for the default header transformations. Signed-off-by: Lior Okman <lior.okman@sap.com> * Make 'gen-check' happy Signed-off-by: Lior Okman <lior.okman@sap.com> --------- Signed-off-by: Lior Okman <lior.okman@sap.com> Signed-off-by: Yael Shechter <yael.shechter@sap.com> * bug: fix merge race (#2604) Between #2585 & #2581 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Yael Shechter <yael.shechter@sap.com> * feat: downstream mTLS (#2490) * feat: downstream mTLS Relates to #2483 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * configmap provider logic Signed-off-by: Arko Dasgupta <arko@tetrate.io> * gatewayapi translation Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix charts Signed-off-by: Arko Dasgupta <arko@tetrate.io> * tests Signed-off-by: Arko Dasgupta <arko@tetrate.io> * lint Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Yael Shechter <yael.shechter@sap.com> * add timeout to clientTrafficPolicy Signed-off-by: Yael Shechter <yael.shechter@sap.com> * fix comment Signed-off-by: Yael Shechter <yael.shechter@sap.com> * add omitempty Signed-off-by: Yael Shechter <yael.shechter@sap.com> * add cel test for coverage Signed-off-by: Yael Shechter <yael.shechter@sap.com> * run make commands Signed-off-by: Yael Shechter <yael.shechter@sap.com> * change request timeout field name and desc Signed-off-by: Yael Shechter <yael.shechter@sap.com> * tidy up comment Signed-off-by: Yael Shechter <yael.shechter@sap.com> * fix cel test Signed-off-by: Yael Shechter <yael.shechter@sap.com> * fix typo Signed-off-by: Yael Shechter <yael.shechter@sap.com> * run generate Signed-off-by: Yael Shechter <yael.shechter@sap.com> --------- Signed-off-by: Lior Okman <lior.okman@sap.com> Signed-off-by: Yael Shechter <yael.shechter@sap.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: Lior Okman <lior.okman@sap.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: zirain <zirain2009@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the API introduced in #2500