Migrate EngFlow configurations from rbe_autoconfig to rbe_configs_gen#2037
Merged
jpsim merged 7 commits intoenvoyproxy:mainfrom Feb 3, 2022
Merged
Migrate EngFlow configurations from rbe_autoconfig to rbe_configs_gen#2037jpsim merged 7 commits intoenvoyproxy:mainfrom
jpsim merged 7 commits intoenvoyproxy:mainfrom
Conversation
Following the instructions in https://github.com/bazelbuild/bazel-toolchains Specifically: $ ./rbe_configs_gen \ --bazel_version="4.2.1" \ --toolchain_container="docker.io/envoyproxy/envoy-build-ubuntu:514e2f7bc36c1f0495a523b16aab9168a4aa13b6" \ --exec_os="linux" \ --target_os="linux" \ --output_src_root="/path/to/envoy-mobile" \ --output_config_path="third_party/rbe_configs" \ --cpp_env_json=clang.json \ --generate_java_configs=False $ cat clang.json {"CC": "/opt/llvm/bin/clang", "CXX": "/opt/llvm/bin/clang++"} Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Member
|
@Yannic can you review? is this how this should work now? |
Contributor
|
@lfpino PTAL |
Contributor
|
I'll take a look @keith, can you please add me as a reviewer? |
Member
|
I cannot, maybe you have to be part of the org to be added as a reviewer? |
Contributor
Author
|
The GitHub UI also won't let me.
|
Contributor
|
I guess I'll review nonetheless :') |
lfpino
suggested changes
Feb 3, 2022
Contributor
lfpino
left a comment
There was a problem hiding this comment.
The change is almost there but the current toolchain would break coverage so please fix that one first.
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
So that only the platforms that need the `SYS_PTRACE` Docker capability have it. Signed-off-by: JP Simard <jp@jpsim.com>
This reverts commit f7fdb4c. Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
Author
|
Thanks for the review, @lfpino.
Can you please take another look? |
keith
approved these changes
Feb 3, 2022
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Feb 3, 2022
* main: envoy: 71248e512 (envoyproxy#2027) Migrate EngFlow configurations from rbe_autoconfig to rbe_configs_gen (envoyproxy#2037) timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the instructions in https://github.com/bazelbuild/bazel-toolchains
Specifically:
This will be necessary to migrate to Bazel 5.0.0.