Merged
Conversation
Signed-off-by: JP Simard <jp@jpsim.com>
60e93ef to
93b9c63
Compare
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
* main: [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030) Enable the "received byte count" feature. (envoyproxy#2004) Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
commented
Feb 1, 2022
bazel/envoy_mobile_repositories.bzl
Outdated
| name = "build_bazel_rules_android", | ||
| urls = ["https://github.com/bazelbuild/rules_android/archive/v0.1.1.zip"], | ||
| sha256 = "cd06d15dd8bb59926e4d65f9003bfc20f9da4b2519985c27e190cddc8b7a7806", | ||
| sha256 = "7cb2b2e11aafe08b2ccb6eeb11f21f52c45e1ad1cdd0132ddf7bde8462bd9e20", |
Contributor
Author
There was a problem hiding this comment.
There was a problem hiding this comment.
The change in the zip files was the result of a change on Github's side. They've rolled back the change that they believe caused the change in zip files:
https://twitter.com/tgummerer/status/1488493440103030787
So the hash should go back to what it was before.
Contributor
Author
There was a problem hiding this comment.
Thanks for linking to that twitter thread. I'll switch back once GitHub starts serving the archive with the previous checksum again (still serving 7cb2b2e right now).
Contributor
Author
There was a problem hiding this comment.
An alternate URL (https://github.com/bazelbuild/rules_android/archive/refs/tags/v0.1.1.zip) produces the expected checksum.
by changing the URL for the zip archive Signed-off-by: JP Simard <jp@jpsim.com>
* main: timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Feb 3, 2022
* main: envoy: 71248e512 (envoyproxy#2027) Migrate EngFlow configurations from rbe_autoconfig to rbe_configs_gen (envoyproxy#2037) timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: envoyproxy/envoy@519774f...71248e5