Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
goaway
approved these changes
Feb 3, 2022
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Feb 3, 2022
* main: timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) Signed-off-by: JP Simard <jp@jpsim.com>
| }; | ||
| bridge_callbacks_.on_complete = [](envoy_stream_intel, envoy_final_stream_intel final_intel, | ||
| void* context) -> void* { | ||
| validateStreamIntel(final_intel); |
Contributor
There was a problem hiding this comment.
Is doing asserts inside a callback a usual strategy for C++ tests in Envoy?
Contributor
Author
There was a problem hiding this comment.
arguably not optimal but I guess I found it cleaner than a ton of copy-paste code.
Contributor
There was a problem hiding this comment.
Don't worry - I checked other EM tests, and assert in callbacks seems rather popular.
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Feb 3, 2022
* main: envoy: 71248e512 (envoyproxy#2027) Migrate EngFlow configurations from rbe_autoconfig to rbe_configs_gen (envoyproxy#2037) timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alyssa Wilk alyssar@chromium.org
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]