Revert "config: unification of delta and SotW gRPC xDS (#8478)"#8939
Merged
mattklein123 merged 1 commit intomasterfrom Nov 8, 2019
Merged
Revert "config: unification of delta and SotW gRPC xDS (#8478)"#8939mattklein123 merged 1 commit intomasterfrom
mattklein123 merged 1 commit intomasterfrom
Conversation
This reverts commit 443bc33. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
lizan
approved these changes
Nov 7, 2019
Contributor
Member
Author
|
Sorry @fredlas that's not the way we handle issues like this. We will revert and then we can resubmit the other PR once we agree on the right integration test coverage to prevent the reported issue. |
mattklein123
added a commit
that referenced
this pull request
Nov 15, 2019
…e_names_ (#8918)" This reverts commit 80aedc1. Revert "config: rename NewGrpcMuxImpl -> GrpcMuxImpl (#8919)" This reverts commit 6d50553. Revert "config: reinstate #8478 (unification of delta and SotW xDS), reverted by #8939 (#8974)" This reverts commit a37522c. Signed-off-by: Matt Klein <mklein@lyft.com>
mattklein123
added a commit
that referenced
this pull request
Nov 16, 2019
…e_names_ (#8918)" (#9044) This reverts commit 80aedc1. Revert "config: rename NewGrpcMuxImpl -> GrpcMuxImpl (#8919)" This reverts commit 6d50553. Revert "config: reinstate #8478 (unification of delta and SotW xDS), reverted by #8939 (#8974)" This reverts commit a37522c. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 443bc33.