config: minor cleanup: remove DeltaSubscriptionState::resource_names_#8918
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Nov 14, 2019
wgallagher:removeresourcenames
Merged
config: minor cleanup: remove DeltaSubscriptionState::resource_names_#8918mattklein123 merged 1 commit intoenvoyproxy:masterfrom wgallagher:removeresourcenames
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
wgallagher:removeresourcenames
Conversation
Signed-off-by: Bill Gallagher <bgallagher@lyft.com>
mattklein123
added a commit
that referenced
this pull request
Nov 15, 2019
…e_names_ (#8918)" This reverts commit 80aedc1. Revert "config: rename NewGrpcMuxImpl -> GrpcMuxImpl (#8919)" This reverts commit 6d50553. Revert "config: reinstate #8478 (unification of delta and SotW xDS), reverted by #8939 (#8974)" This reverts commit a37522c. Signed-off-by: Matt Klein <mklein@lyft.com>
mattklein123
added a commit
that referenced
this pull request
Nov 16, 2019
…e_names_ (#8918)" (#9044) This reverts commit 80aedc1. Revert "config: rename NewGrpcMuxImpl -> GrpcMuxImpl (#8919)" This reverts commit 6d50553. Revert "config: reinstate #8478 (unification of delta and SotW xDS), reverted by #8939 (#8974)" This reverts commit a37522c. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: minor cleanup, remove unnecessary field DeltaSubscriptionState::resource_names_
Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: N/A