config: rename NewGrpcMuxImpl -> GrpcMuxImpl#8919
config: rename NewGrpcMuxImpl -> GrpcMuxImpl#8919mattklein123 merged 3 commits intoenvoyproxy:masterfrom wgallagher:renamenewgrpcmuximpl
Conversation
|
Thanks @wgallagher can you fix format and DCO (see contributor guide for setting things up)? /wait |
|
Putting into waiting while we deal with the revert. /wait |
Signed-off-by: Bill Gallagher <bgallagher@lyft.com>
|
@wgallagher please fix format and undraft when ready for review. Thank you. /wait |
|
Please fix DCO. /wait |
Signed-off-by: Bill Gallagher <bgallagher@lyft.com>
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small comment. Thank you!
/wait
| namespace Envoy { | ||
| namespace Config { | ||
|
|
||
| NewGrpcMuxImpl::NewGrpcMuxImpl(std::unique_ptr<SubscriptionStateFactory> subscription_state_factory, |
There was a problem hiding this comment.
Can you rename the files also to get rid of new? (Here and in all the other files).
Signed-off-by: Bill Gallagher <bgallagher@lyft.com>
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with one question.
/wait-any
| ], | ||
| ) | ||
|
|
||
| envoy_cc_test( |
There was a problem hiding this comment.
Did we lose coverage here somehow?
There was a problem hiding this comment.
this class contained a single test which seemed to be duplicated in grpc_mux_impl_test.cc
There was a problem hiding this comment.
Specifically, TEST_F(GrpcMuxImplTest, DiscoveryResponseNonexistentSub) which does everything this test does and adds a few additional checks.
…e_names_ (#8918)" This reverts commit 80aedc1. Revert "config: rename NewGrpcMuxImpl -> GrpcMuxImpl (#8919)" This reverts commit 6d50553. Revert "config: reinstate #8478 (unification of delta and SotW xDS), reverted by #8939 (#8974)" This reverts commit a37522c. Signed-off-by: Matt Klein <mklein@lyft.com>
…e_names_ (#8918)" (#9044) This reverts commit 80aedc1. Revert "config: rename NewGrpcMuxImpl -> GrpcMuxImpl (#8919)" This reverts commit 6d50553. Revert "config: reinstate #8478 (unification of delta and SotW xDS), reverted by #8939 (#8974)" This reverts commit a37522c. Signed-off-by: Matt Klein <mklein@lyft.com>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: rename NewGrpcMuxImpl -> GrpcMuxImpl
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]