Disallow specifying custom resolver name for STRICT and LOGICAL dns#6799
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom May 6, 2019
Merged
Disallow specifying custom resolver name for STRICT and LOGICAL dns#6799mattklein123 merged 6 commits intoenvoyproxy:masterfrom
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
Merge latest master from envoy
Merge envoy master
…GICAL_DNS Signed-off-by: Sumukh Shivaprakash <sumukhs@microsoft.com>
Signed-off-by: Sumukh Shivaprakash <sumukhs@microsoft.com>
Member
|
Thanks for picking this up. I think you should definitely document this in address.proto and I think it deserves an entry in the release notes (version_history.rst) as well. |
Contributor
Author
Makes sense. Will post an update. |
Signed-off-by: Sumukh Shivaprakash <sumukhs@microsoft.com>
Contributor
Author
|
@zuercher - Pushed a new update. |
Member
|
/assign @mattklein123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: An exception is thrown to the user if a custom resolver name is specified when using strict or logical dns in the address section of the endpoints.
Risk Level: Low
Testing: //test/...
Docs Changes: This is a behavior change in an error condition. Would documenting this change in the proto file be sufficient?
Release Notes: n/a
Fixes #3553