Merged
Conversation
Some negative tests external to this codebase exercise config errors resulting in thrown exceptions during server construction, which takes an altered path to shutdown. Notably, any cleanups in post() callbacks may not be called. This was causing memory-leaks in unit-tests. This PR fixes that by keeping a copy of the rejected-stats set in "purgatory" so they can be removed on destruction from ThreadLocalStore if they don't get cleaned up by the post(). Risk Level: medium Testing: //test/... Docs Changes: n/a Release Notes: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com>
This didn't get fully migrated when we switched to common corpus for h1_capture_fuzz_test and h1_capture_direct_response_fuzz_test. Risk level: Low Testing: bazel test //test/integration:h1_capture_fuzz_test -c dbg --config=clang-asan Signed-off-by: Harvey Tuch <htuch@google.com>
currently envoy is only checking for the: connection: close header and not the: proxy-connection: close header. this presents a problem with HPE, because HPE marks a connection as closed when you specify proxy-connection: close. this can cause problems in a scenario where a load balancer is forwarding traffic to envoy which does not support proxy-connection header. in this case the load balancer will try to keep forwarding data onto envoy regardless of the fact that HPE think it's closed. thus causing a 400. this is a common scenario since proxy-connection is not standard. this commit fixes that by properly sending connection: close back in a response whenever we receive a: proxy-connection: close. this should properly get the proxy to close the connection as long as it is spec compliant. Risk Level: Medium Testing: unit tests, manual integration tests. Docs Changes: None Release Notes: None Signed-off-by: Eric <ecoan@rust-lang.life>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Sumukh Shivaprakash <sumukhs@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]