stats: Cleanup rejects on throw#6777
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom May 2, 2019
Merged
Conversation
…ore. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
aunu53
approved these changes
May 2, 2019
htuch
reviewed
May 2, 2019
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
Some negative tests external to this codebase exercise config errors resulting in thrown exceptions during server construction, which takes an altered path to shutdown. Notably, any cleanups in post() callbacks may not be called. This was causing memory-leaks in unit-tests. This PR fixes that by keeping a copy of the rejected-stats set in "purgatory" so they can be removed on destruction from ThreadLocalStore if they don't get cleaned up by the post(). Risk Level: medium Testing: //test/... Docs Changes: n/a Release Notes: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Some negative tests external to this codebase exercise config errors resulting in thrown exceptions during server construction, which takes an altered path to shutdown. Notably, any cleanups in post() callbacks may not be called. This was causing memory-leaks in unit-tests. This PR fixes that by keeping a copy of the rejected-stats set in "purgatory" so they can be removed on destruction from ThreadLocalStore if they don't get cleaned up by the post().
Risk Level: medium
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a