Conversation
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
e4e02eb to
10ff37c
Compare
|
this requires some upstream bazel changes before it will be green |
|
cc @mmorel-35 |
10ff37c to
a1de1d7
Compare
a4f9fa7 to
33fa329
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
| switched_rules.use_languages( | ||
| cc = True, | ||
| go = True, | ||
| ) |
There was a problem hiding this comment.
You might also need to add grpc = True.
The enovy_api package must support bzlmod in order for other transitive deps of envoy to support it as well. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
33fa329 to
f2d3c26
Compare
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
@mering pushed some updates |
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
@keith Thanks! Looks like you need to format your code https://github.com/envoyproxy/envoy/actions/runs/12022333130. Apart from this, is there anything else missing? |
|
i can't actually tell what failed there, but im attempting to run it locally to see. there might be more to fix once we get past the precheck CI |
|
can't actually tell why that CI job is failing, running that command locally didn't result in any changes |
|
this 2024/11/26 02:00:17 Downloading https://releases.bazel.build/6.5.0/release/bazel-6.5.0-linux-x86_64...
and this ... 2024/11/26 02:00:47 Downloading https://releases.bazel.build/7.4.1/release/bazel-7.4.1-linux-x86_64...
not sure why its using different bazel versions - but its a bazel fight |
|
Looks like that is from this script: envoy/tools/proto_format/proto_format.sh Lines 35 to 36 in d9e1d22 since it does a cd before running, and the version file isn't in there. I can symlink it there, but interestingly that part also isn't new |
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
checking other ci (eg here https://github.com/envoyproxy/envoy/actions/runs/12128588097/job/33815284187#step:16:564) its using the same (already installed perhaps) bazel version i guess with bzlmod, if you dont specify, bazelisk assumes 7+ for the better support and install different version |
|
ah actually I think it's because I created |
| /bazel-* | ||
| /mobile/bazel-* | ||
| bazel-* | ||
| MODULE.bazel.lock |
There was a problem hiding this comment.
im still unconvinced about the wisdom of not checking in lock files
There was a problem hiding this comment.
yea i think once we're on 7.4+ we can check them in, just have to add a CI job validating they're up to date. the format isn't very stable in 6.x tho
|
How is https://github.com/envoyproxy/data-plane-api created from this repo? Will the symlink be materialized? |
There was a problem hiding this comment.
This is now included in main via #37659. Please sync.
| "@com_google_absl//absl/strings:str_format", | ||
| "@com_google_protobuf//:protobuf", | ||
| "@com_google_protobuf//src/google/protobuf/compiler:code_generator", | ||
| "@com_google_protobuf//src/google/protobuf/compiler:retention", |
| bazel_dep(name = "googletest", version = "1.14.0.bcr.1", repo_name = "com_google_googletest") | ||
| bazel_dep(name = "grpc", version = "1.62.1", repo_name = "com_github_grpc_grpc") | ||
| bazel_dep(name = "opencensus-proto", version = "0.4.1.bcr.1", repo_name = "opencensus_proto") | ||
| bazel_dep(name = "opentelemetry-proto", version = "1.4.0", repo_name = "opentelemetry_proto") |
There was a problem hiding this comment.
Please update to include bazelbuild/bazel-central-registry#3415
| bazel_dep(name = "opentelemetry-proto", version = "1.4.0", repo_name = "opentelemetry_proto") | |
| bazel_dep(name = "opentelemetry-proto", version = "1.4.0.bcr.1", repo_name = "opentelemetry_proto") |
The necessary modifications have been merged to main in #37662. Please sync past this.
- Based on envoyproxy/envoy#34355 - Requires #3420 and #3423 - Upstreaming target name alignment in #3415 and envoyproxy/envoy#37662 - Issue for patched Protobuf: envoyproxy/envoy#37669
There was a problem hiding this comment.
You might want to introduce this in a separate PR to fix the CI issues unrelated to Bzlmod independently.
|
FYI: I uploaded a first version to BCR in bazelbuild/bazel-central-registry#3424. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
The enovy_api package must support bzlmod in order for other transitive
deps of envoy to support it as well.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com