Align target names for opentelemetry-proto with BCR#37662
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Dec 16, 2024
mering:align-opentelemetry-proto-bcr
Merged
Align target names for opentelemetry-proto with BCR#37662phlax merged 1 commit intoenvoyproxy:mainfrom mering:align-opentelemetry-proto-bcr
phlax merged 1 commit intoenvoyproxy:mainfrom
mering:align-opentelemetry-proto-bcr
Conversation
|
Hi @mering, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
This is a requirement for compatibility with Bzlmod. Signed-off-by: maleo <maleo@google.com>
phlax
approved these changes
Dec 16, 2024
Contributor
|
/lgtm api |
meteorcloudy
pushed a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Dec 19, 2024
- Based on envoyproxy/envoy#34355 - Requires #3420 and #3423 - Upstreaming target name alignment in #3415 and envoyproxy/envoy#37662 - Issue for patched Protobuf: envoyproxy/envoy#37669
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align target names for opentelemetry-proto with Bazel Central Registry.
This is a requirement for compatibility with Bzlmod.