Migrate from Add*() to Record*() set of methods#37659
Merged
adisuissa merged 1 commit intoenvoyproxy:mainfrom Dec 16, 2024
mering:protobuf-compatibility
Merged
Migrate from Add*() to Record*() set of methods#37659adisuissa merged 1 commit intoenvoyproxy:mainfrom mering:protobuf-compatibility
adisuissa merged 1 commit intoenvoyproxy:mainfrom
mering:protobuf-compatibility
Conversation
|
Hi @mering, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
In Protobuf v22 RecordWarning() and RecordError() have been introduced and AddWarning() and AddError() deprecated In Protobuf v26 AddWarning() and AddError() have been removed Co-authored-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: maleo <maleo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecordWarning()andRecordError()have been introduced andAddWarning()andAddError()deprecatedAddWarning()andAddError()have been removed