bazel: move shared action_env above enable_platform_specific_config#20852
Merged
keith merged 1 commit intoenvoyproxy:mainfrom Apr 18, 2022
Conversation
This fixes an issue where the PATH wasn't actually set to what we tried to force as the default on macOS. I'm not sure if this is a bazel bug or not, but either way it's surprising behavior. bazelbuild/bazel#15270 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
phlax
approved these changes
Apr 18, 2022
mum4k
added a commit
to envoyproxy/nighthawk
that referenced
this pull request
Apr 19, 2022
- updated `.bazelrc` based on envoyproxy/envoy#20852 and envoyproxy/envoy#20813. Disabling platform mappings in our configuration, since we don't need them. - no changes in `.bazelversion`, `ci/run_envoy_docker.sh` or `tools/gen_compilation_database.py`. - switching integration tests that verify custom TLS configuration to another two ciphers that are supported in the default Envoy server configuration after envoyproxy/envoy#20643. Signed-off-by: Jakub Sobon <mumak@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the PATH wasn't actually set to what we tried
to force as the default on macOS. I'm not sure if this is a bazel bug or
not, but either way it's surprising behavior.
bazelbuild/bazel#15270
Signed-off-by: Keith Smiley keithbsmiley@gmail.com