tls: remove SHA-1 cipher suites from the defaults on the server-side#20643
Merged
wrowe merged 1 commit intoenvoyproxy:mainfrom Apr 16, 2022
derekguo001:remove-sha1-cipher-suite
Merged
tls: remove SHA-1 cipher suites from the defaults on the server-side#20643wrowe merged 1 commit intoenvoyproxy:mainfrom derekguo001:remove-sha1-cipher-suite
wrowe merged 1 commit intoenvoyproxy:mainfrom
derekguo001:remove-sha1-cipher-suite
Conversation
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
Per #5401 - @PiotrSikora can you confirm it's time to land this deprecation, and that the changes entry is sufficient? |
PiotrSikora
previously approved these changes
Apr 6, 2022
Contributor
PiotrSikora
left a comment
There was a problem hiding this comment.
This change looks fine, but as usual, I'd recommend merging it after release instead of right before it.
Contributor
|
/wait on the quarterly release coming up mid-April |
Signed-off-by: derekguo001 <dong.guo@intel.com>
Contributor
Agreed, moving it forward once it clears CI. /retest |
|
Retrying Azure Pipelines: |
Contributor
|
/lgtm |
|
please specify a single label can be specified |
wrowe
approved these changes
Apr 16, 2022
vehre-x41
pushed a commit
to vehre-x41/envoy
that referenced
this pull request
Apr 19, 2022
…nvoyproxy#20643) Signed-off-by: derekguo001 <dong.guo@intel.com> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
mum4k
added a commit
to envoyproxy/nighthawk
that referenced
this pull request
Apr 19, 2022
- updated `.bazelrc` based on envoyproxy/envoy#20852 and envoyproxy/envoy#20813. Disabling platform mappings in our configuration, since we don't need them. - no changes in `.bazelversion`, `ci/run_envoy_docker.sh` or `tools/gen_compilation_database.py`. - switching integration tests that verify custom TLS configuration to another two ciphers that are supported in the default Envoy server configuration after envoyproxy/envoy#20643. Signed-off-by: Jakub Sobon <mumak@google.com>
lizan
pushed a commit
to envoyproxy/data-plane-api
that referenced
this pull request
May 13, 2022
…(#21240) Related PR: envoyproxy/envoy#20643 Signed-off-by: derekguo001 <dong.guo@intel.com> Mirrored from https://github.com/envoyproxy/envoy @ 81cebf6b12b13f490cc0ff8c77abaaffc7ef590f
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…nvoyproxy#20643) Signed-off-by: derekguo001 <dong.guo@intel.com>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…nvoyproxy#21240) Related PR: envoyproxy#20643 Signed-off-by: derekguo001 <dong.guo@intel.com>
oschaaf
pushed a commit
to maistra/envoy
that referenced
this pull request
Oct 26, 2022
…(#21240) Related PR: envoyproxy/envoy#20643 Signed-off-by: derekguo001 <dong.guo@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: derekguo001 dong.guo@intel.com
Commit Message: tls: remove SHA-1 cipher suites from the defaults on the server-side
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes: tls: remove SHA-1 cipher suites from the defaults on the server-side
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #5400
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]