bazel: add mobile platform mappings#20813
Merged
keith merged 1 commit intoenvoyproxy:mainfrom Apr 14, 2022
Merged
Conversation
snowp
previously approved these changes
Apr 13, 2022
Contributor
snowp
left a comment
There was a problem hiding this comment.
LGTM pending green CI. Sounds like this is a noop unless we're building mobile platforms, so this is as fine as any (especially considering the potential plans to bring EM into the repo).
As part of supporting rust in envoy and envoy mobile we have to use the newer bazel mechanisms for changing platforms. During the transition between the old version (which the android + iOS toolchains use) and the new version (used by rules_rust), we have to provide some mappings for the specific platforms. We could do this in envoy-mobile only if we'd prefer, but since there is already some mobile specific build infra in this repo I chose to put it here first. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
7e5283b to
e660bd7
Compare
This was referenced Apr 14, 2022
mum4k
added a commit
to envoyproxy/nighthawk
that referenced
this pull request
Apr 19, 2022
- updated `.bazelrc` based on envoyproxy/envoy#20852 and envoyproxy/envoy#20813. Disabling platform mappings in our configuration, since we don't need them. - no changes in `.bazelversion`, `ci/run_envoy_docker.sh` or `tools/gen_compilation_database.py`. - switching integration tests that verify custom TLS configuration to another two ciphers that are supported in the default Envoy server configuration after envoyproxy/envoy#20643. Signed-off-by: Jakub Sobon <mumak@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of supporting rust in envoy and envoy mobile we have to use the
newer bazel mechanisms for changing platforms. During the transition
between the old version (which the android + iOS toolchains use) and the
new version (used by rules_rust), we have to provide some mappings for
the specific platforms. We could do this in envoy-mobile only if we'd
prefer, but since there is already some mobile specific build infra in
this repo I chose to put it here first.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com