stats: change Stats::ScopePtr references to Stats::ScopeSharedPtr#19790
Merged
KBaichoo merged 16 commits intoenvoyproxy:mainfrom Feb 21, 2022
Merged
stats: change Stats::ScopePtr references to Stats::ScopeSharedPtr#19790KBaichoo merged 16 commits intoenvoyproxy:mainfrom
KBaichoo merged 16 commits intoenvoyproxy:mainfrom
Conversation
…fined type. Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
added a commit
that referenced
this pull request
Feb 16, 2022
…r, leaving ScopePtr alias behind (#19791) Commit Message: To support an algorithmic solution to a long burst of CPU on admin /stats with a large # clusters, we need to hold scopes in shared pointers. This PR makes that change and updates the usage within stats to reference scopes as ScopeSharedPtr rather than ScopePtr, and adds enable_shared_from_this as a Scope super-class so existing APIs that pass Scope& don't need to change. This leaves behind a ScopePtr alias to ScopeSharedPtr temporarily to (a) make this PR be reviewable and (b) avoid breaking other repos that may reference ScopePtr. It will be easier to submit this PR first, then a external repos can rename their references, and we can do a follow-up PR that removes ScopePtr to avoid longer term confusion. That PR would like like #19790 which has 90 changed files in addition to the semantic change. Once this is merged, that PR will just be a strict rename and will be a lot easier to review. This PR blocks #19693 which implements the admin change requiring holding onto a shared scope ptr. Additional Description: Risk Level: low Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
|
//test/extensions/network/dns_resolver/apple:apple_dns_impl_test FAILED TO BUILD /wait |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…re is coming from Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
I was not able to figure out what the MacOS build failure was, so I'm going to let this go through CI with zero changes and then I'll break this up into much smaller PRs to iterate through this name-change across the codebase. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
KBaichoo
approved these changes
Feb 21, 2022
Contributor
KBaichoo
left a comment
There was a problem hiding this comment.
lgtm, that sounds like a good strategy.
rojkov
pushed a commit
that referenced
this pull request
Feb 28, 2022
…extensions (#20073) This is a continuation of #19790 this time hitting the extensions directories, but specifically excluding the apple DNS resolver impl which has some issue with this rename that is hard to diagnose from the CI logs. We'll come back to that one last. Risk Level: low Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com>
This was referenced Apr 19, 2022
jmarantz
added a commit
that referenced
this pull request
Apr 20, 2022
…eSharedPtr (#20888) Commit Message: Follow-up to #19791, #19790 and #20871, finishing off all remaining ScopePtr references. One more PR to go which will be to remove the ScopePtr definition, but first need to make sure this doesn't break any references outside the repo. Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…eSharedPtr (envoyproxy#20888) Commit Message: Follow-up to envoyproxy#19791, envoyproxy#19790 and envoyproxy#20871, finishing off all remaining ScopePtr references. One more PR to go which will be to remove the ScopePtr definition, but first need to make sure this doesn't break any references outside the repo. Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Follow-up to #19791 which changed Stats::ScopePtr to really be a shared_ptr, leaving both ScopePtr and ScopeSharedPtr referencing the same type:
std::shared_ptr<Stats::Scope>, and changing references within theStats::namespace. This PR changes all in-repo references to ScopePtr into ScopeSharedPtr.After this PR we will still have the Stats::ScopePtr alias here for one more round, giving out-of-repo codebases a chance to remove the references. The final PR to remove ScopePtr should will just have that one-line change in it, so it would be easy to roll back if needed.
Additional Description: To reviewers: This PR is a strict rename between equivalent aliases, and though it hits a lot of files in it, it should be quick to go through. There are no semantic changes. Thank you!
Risk Level: low -- this is just changing a large number of references between two equivalent aliases.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a