Skip to content

stats: change Stats::ScopePtr references to Stats::ScopeSharedPtr in extensions#20073

Merged
rojkov merged 6 commits intoenvoyproxy:mainfrom
jmarantz:shared-scopes-2
Feb 28, 2022
Merged

stats: change Stats::ScopePtr references to Stats::ScopeSharedPtr in extensions#20073
rojkov merged 6 commits intoenvoyproxy:mainfrom
jmarantz:shared-scopes-2

Conversation

@jmarantz
Copy link
Copy Markdown
Contributor

@jmarantz jmarantz commented Feb 22, 2022

Signed-off-by: Joshua Marantz jmarantz@google.com
Commit Message: This is a continuation of #19790 this time hitting the extensions directories, but specifically excluding the apple DNS resolver impl which has some issue with this rename that is hard to diagnose from the CI logs.

We'll come back to that one last.
Additional Description:
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

…extensions

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #20073 was opened by jmarantz.

see: more, trace.

…_dns_impl.h

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz marked this pull request as ready for review February 25, 2022 18:17
Copy link
Copy Markdown
Member

@rojkov rojkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@rojkov rojkov merged commit c444c6e into envoyproxy:main Feb 28, 2022
@jmarantz jmarantz deleted the shared-scopes-2 branch February 28, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants