stats: change all remaining Stats::ScopePtr references to Stats::ScopeSharedPtr#20888
Merged
jmarantz merged 2 commits intoenvoyproxy:mainfrom Apr 20, 2022
Merged
stats: change all remaining Stats::ScopePtr references to Stats::ScopeSharedPtr#20888jmarantz merged 2 commits intoenvoyproxy:mainfrom
jmarantz merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
For the switch what are you waiting for exactly? Perhaps marking the old typedef as deprecated could be a good approach to warning other repos. |
Contributor
Author
|
`deprecated` sgtm -- am also going to add a lint check.
There are refs in Nighthawk and a few in Google's private repo which I will
fix; there may be others in some codebases I can't see.
…On Tue, Apr 19, 2022 at 9:10 PM Kevin Baichoo ***@***.***> wrote:
For the switch what are you waiting for exactly? Perhaps marking the old
typedef as deprecated
<https://en.cppreference.com/w/cpp/language/attributes/deprecated> could
be a good approach to warning other repos.
—
Reply to this email directly, view it on GitHub
<#20888 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO2IPMRH7D2UUSD5J7NBSDVF5KRXANCNFSM5TZUSB4Q>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Contributor
Author
|
#20896 adds the lint check and deprecated warning, though that warning doesn't seem to come out for me when I run bazel build on a file where I've used the old name. |
Contributor
|
alas, we silence deprecated warning on linux: #19468 |
Contributor
Author
|
Yeah I think it's still good as documentation though. In theory clang-tidy should catch it, but it doesn't. |
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…eSharedPtr (envoyproxy#20888) Commit Message: Follow-up to envoyproxy#19791, envoyproxy#19790 and envoyproxy#20871, finishing off all remaining ScopePtr references. One more PR to go which will be to remove the ScopePtr definition, but first need to make sure this doesn't break any references outside the repo. Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Follow-up to #19791, #19790 and #20871, finishing off all remaining ScopePtr references. One more PR to go which will be to remove the ScopePtr definition, but first need to make sure this doesn't break any references outside the repo.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a