Lightstep includes and gold#1884
Conversation
This is another attempt to prevent build failures when using non-sandbox mode. Instead of trying to find things under `src/c++11/` second, we just drop that entire directory from the search path. Signed-off-by: John Millikin <jmillikin@stripe.com>
f5479c9 to
b1e02c8
Compare
bazel/genrule_repository.bzl
Outdated
There was a problem hiding this comment.
Can you describe the versions involved? We can't bump CI to a newer version and set that as the floor?
There was a problem hiding this comment.
@mattklein123 reported errors with /usr/bin/g++-5, and the linked StackOverflow post indicates it affects some unknown version range in (5.x, 6.x).
Upgrading CI GCC to v7 would probably fix this but I don't want to start doing wild stuff until the build is more settled.
There was a problem hiding this comment.
OK, please just add to comment. Thanks.
bazel/external/lightstep.BUILD
Outdated
There was a problem hiding this comment.
I guess this kind of hackery is worth it for the globs, but this goes back to my original rationale for preferring a repository_rule for the full build over genrule; you can know all the final headers and glob them in place.
This comment is really non-actionable, but I think as we move more stuff to be genrule based, we should look to see what happens with this.
This fixes `/usr/bin/ld: unrecognized option '--push-state'` errors caused when older versions of G++ use gold-specific options to GNU LD. Signed-off-by: John Millikin <jmillikin@stripe.com>
b1e02c8 to
1409d5e
Compare
* Reduce log level for jwt filter (envoyproxy#1866) * Update_Dependencies (envoyproxy#1873) * Correctly clean up headers used for payload from JWT authentication (envoyproxy#1879) * Correctly clean up headers used for payload from JWT authentication * Clang * Update_Dependencies (envoyproxy#1883) * destination.principal derivation fix (envoyproxy#1884) * fix attribute extraction Signed-off-by: Kuat Yessenov <kuat@google.com> * seed mock Signed-off-by: Kuat Yessenov <kuat@google.com> * merge 1.0 to master * Update API SHA (envoyproxy#1891) * add needed dependencies for circle ci
Use only lightstep headers installed to its prefix.
This is another attempt to prevent build failures when using non-sandbox
mode. Instead of trying to find things under
src/c++11/second, we justdrop that entire directory from the search path.
Try to use
goldfor linking when using G++ in ASAN mode.This fixes
/usr/bin/ld: unrecognized option '--push-state'errorscaused when older versions of G++ use gold-specific options to GNU LD.