router: make StreamInfo non-const in a couple of cases#18625
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Oct 14, 2021
Merged
router: make StreamInfo non-const in a couple of cases#18625mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: router: make StreamInfo non-const in a couple of cases
Additional Description: Envoy Mobile stashes additional request state in StreamInfo FilterState, and requires mutable access to it for the lifetime of the request, including across retries. Making StreamInfo non-const in UpstreamRequest and RetryOptionPredicate affords that access without const_cast hacks.
Risk Level: Low
Testing: Built locally & CI
Signed-off-by: Mike Schore mike.schore@gmail.com