Skip to content

Allow specifying extra build options via BAZEL_EXTRA_OPTIONS#1879

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
ggreenway:build_setup
Oct 17, 2017
Merged

Allow specifying extra build options via BAZEL_EXTRA_OPTIONS#1879
htuch merged 2 commits intoenvoyproxy:masterfrom
ggreenway:build_setup

Conversation

@ggreenway
Copy link
Copy Markdown
Member

Signed-off-by: Greg Greenway ggreenway@apple.com

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
export BAZEL_BUILD_OPTIONS="--strategy=Genrule=standalone --spawn_strategy=standalone \
--verbose_failures ${BAZEL_OPTIONS} --action_env=HOME --action_env=PYTHONUSERBASE \
--jobs=${NUM_CPUS} --show_task_finish"
--jobs=${NUM_CPUS} --show_task_finish ${BAZEL_EXTRA_OPTIONS}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify this as BAZEL_BUILD_EXTRA_OPTIONS? LGTM after that.

@htuch htuch merged commit 1d6f34b into envoyproxy:master Oct 17, 2017
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
* Reduce log level for jwt filter (envoyproxy#1866)

* Update_Dependencies (envoyproxy#1873)

* Correctly clean up headers used for payload from JWT authentication (envoyproxy#1879)

* Correctly clean up headers used for payload from JWT authentication

* Clang

* Update_Dependencies (envoyproxy#1883)

* destination.principal derivation fix (envoyproxy#1884)

* fix attribute extraction

Signed-off-by: Kuat Yessenov <kuat@google.com>

* seed mock

Signed-off-by: Kuat Yessenov <kuat@google.com>

* merge 1.0 to master

* Update API SHA (envoyproxy#1891)

* add needed dependencies for circle ci
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: These logs are quite spammy in practice without any meaningful information. The proposal here is to avoid spamming Android logs and rely on this for unit test debugging or local development debugging.
Risk Level: low
Testing: local

Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: These logs are quite spammy in practice without any meaningful information. The proposal here is to avoid spamming Android logs and rely on this for unit test debugging or local development debugging.
Risk Level: low
Testing: local

Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake pushed a commit that referenced this pull request Mar 3, 2026
…sing (#1879)

**Description**

The `ResponseInputItemUnionParam.UnmarshalJSON` discriminator for `type:
"message"` only checked for an `"id"` field to identify output messages.
Assistant messages sent back in multi-turn conversation history (e.g.,
from Codex CLI) carry `output_text` content but no `"id"`. Without the
`"id"`, parsing fell through to input message types that don't support
output_text, causing `"failed to parse JSON for /v1/responses"`.

The fix adds a secondary check: if `role` is `"assistant"`, try parsing
as `ResponseOutputMessage` before falling through to input message
types.

Specific request payload block cause the issue:

```
{
      "type": "message",
      "role": "assistant",
      "content": [
        {
          "type": "output_text",
          "text": "Hi! I’m here and working. How can I help you with the codex repo or anything else?"
        }
      ]
    },
```

**Related Issues/PRs (if applicable)**
Related PR: #1791

---------

Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants