Move Filesystem::OsSysCalls to Api::OsSysCalls.#1791
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Oct 2, 2017
Merged
Move Filesystem::OsSysCalls to Api::OsSysCalls.#1791mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
This makes it appopriate to use the OsSysCalls abstraction in other areas of the code-base, such as hot-restart. Signed-off-by: Greg Greenway <ggreenway@apple.com>
htuch
previously approved these changes
Oct 2, 2017
Signed-off-by: Greg Greenway <ggreenway@apple.com>
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
This makes it appopriate to use the OsSysCalls abstraction in other areas of the code-base, such as hot-restart. Signed-off-by: Greg Greenway <ggreenway@apple.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This PR is a follow up of initial support for OpenAI's Responses API PR and implements the following pending work. - [x] Replace OpenAI SDK Union types with our own - [x] Improve and add more openinference traces req/res atrributes and configuration. **Related PRs** Related PR: #1649 --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
…sing (#1879) **Description** The `ResponseInputItemUnionParam.UnmarshalJSON` discriminator for `type: "message"` only checked for an `"id"` field to identify output messages. Assistant messages sent back in multi-turn conversation history (e.g., from Codex CLI) carry `output_text` content but no `"id"`. Without the `"id"`, parsing fell through to input message types that don't support output_text, causing `"failed to parse JSON for /v1/responses"`. The fix adds a secondary check: if `role` is `"assistant"`, try parsing as `ResponseOutputMessage` before falling through to input message types. Specific request payload block cause the issue: ``` { "type": "message", "role": "assistant", "content": [ { "type": "output_text", "text": "Hi! I’m here and working. How can I help you with the codex repo or anything else?" } ] }, ``` **Related Issues/PRs (if applicable)** Related PR: #1791 --------- Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This commit adds a new field `context_management` introduced in the new OpenAI's Responses API ref docs[^1] to the request schema. [^1]: https://developers.openai.com/api/reference/resources/responses/methods/create **Related PRs** - #1791 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Co-authored-by: Ignasi Barrera <ignasi@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it appopriate to use the OsSysCalls abstraction
in other areas of the code-base, such as hot-restart.
Signed-off-by: Greg Greenway ggreenway@apple.com