dns ios: attempt to filter out unroutable addresses category#18418
Merged
mattklein123 merged 7 commits intoenvoyproxy:mainfrom Oct 7, 2021
Merged
dns ios: attempt to filter out unroutable addresses category#18418mattklein123 merged 7 commits intoenvoyproxy:mainfrom
mattklein123 merged 7 commits intoenvoyproxy:mainfrom
Conversation
junr03
reviewed
Oct 4, 2021
Member
junr03
left a comment
There was a problem hiding this comment.
lgtm. One small typo, and DCO is missing.
1ad9fee to
e920953
Compare
Signed-off-by: Martin Conte Mac Donell <reflejo@gmail.com>
e920953 to
0be92ab
Compare
Signed-off-by: Martin Conte Mac Donell <reflejo@gmail.com>
junr03
reviewed
Oct 5, 2021
Co-authored-by: Jose Ulises Nino Rivera <junr03@users.noreply.github.com> Signed-off-by: Martin Conte Mac Donell <reflejo@gmail.com>
5c4e795 to
b694de6
Compare
Member
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
Tests are still broken. /wait |
Member
|
@mattklein123 @Reflejo the two failures are only happening on CI and for an expectation of an ipv6 address. I can look into it today. |
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
buildbreaker
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Oct 7, 2021
Picking up [Envoy changes](envoyproxy/envoy@3941b63...5423325). Specifically: - envoyproxy/envoy#18418
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Picking up [Envoy changes](3941b63...5423325). Specifically: - #18418 Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Picking up [Envoy changes](3941b63...5423325). Specifically: - #18418 Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dns ios: attempt to filter out unroutable addresses category
Risk Level: low
Docs Changes: no
Platform Specific Features: ios