ci: bump Envoy sha to 5423325c#1868
Merged
buildbreaker merged 7 commits intoenvoyproxy:mainfrom Oct 7, 2021
Merged
Conversation
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
junr03
previously approved these changes
Oct 7, 2021
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
junr03
reviewed
Oct 7, 2021
library/common/engine.cc
Outdated
|
|
||
| envoy_status_t Engine::main(const std::string config, const std::string log_level) { | ||
| // Using unique_ptr ensures main_common's lifespan is strictly scoped to this function. | ||
| Thread::MainThread main_thread_; |
Member
There was a problem hiding this comment.
Can we register this in EngineCommon like Envoy is doing: envoyproxy/envoy@bcf6729#diff-51c9c3d59b80fbaef57384b42c3137d0a8c1c5cd46ebd86baeb48bd4d709f0d6R228?
Also two nits:
- Can we change the name to something like register_main_thread so that it is not confused?
- FYI suffix
_is used as a convetion for instance variables not for local variables like this one.
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
ec1d6c6 to
aaaab5f
Compare
junr03
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up Envoy changes.
Specifically: