tracing: Decorator to define operation/span name associated with matc…#1622
Closed
objectiser wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
tracing: Decorator to define operation/span name associated with matc…#1622objectiser wants to merge 1 commit intoenvoyproxy:masterfrom
objectiser wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
…hed criteria (path, prefix, future regex). resolves envoyproxy#1527
objectiser
commented
Sep 12, 2017
| name = "envoy_api", | ||
| remote = REPO_LOCATIONS["envoy_api"], | ||
| commit = "b9e89d760d4849812b43a0979aa756137563bf83", | ||
| commit = "11582c112f920233b358e89898316f2cda8dc59a", |
Contributor
Author
There was a problem hiding this comment.
As mentioned in the main PR description, this is currently using my repo branch of envoy-api - so this would need merging before this PR.
objectiser
commented
Sep 12, 2017
| "jinja2": "https://github.com/pallets/jinja.git", | ||
| "grpc_transcoding": "https://github.com/grpc-ecosystem/grpc-httpjson-transcoding.git", | ||
| "envoy_api": "https://github.com/lyft/envoy-api.git", | ||
| "envoy_api": "https://github.com/objectiser/envoy-api.git", |
objectiser
commented
Sep 12, 2017
| if (config.operationName() == OperationName::Egress) { | ||
| span_name.append(" "); | ||
| span_name.append(request_headers.Host()->value().c_str()); | ||
| span_name = request_headers.Host()->value().c_str(); |
Contributor
Author
There was a problem hiding this comment.
These changes reflect what is used within zipkin - i.e. it ignored the span name passed in, and instead just used the host header.
Doesn't appear that the lightstep tracer is specifically using the Egress/Ingress values, so must just be passed through to the backend tracing system - so we might need to double check with them that they are ok with these changed (default) values.
Contributor
Author
|
Will create a new PR once tracing details moved to |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
modifying the NetworkConfigurationFilter to do asynchronous DNS lookups for non-IP-address proxies. If address resolution fails, the request will be short circuited by sendLocalReply rather than being sent upstream without being proxied. This PR also changes ConnectivityManager to have a pure API and an Impl for testing. Risk Level: low Testing: unit tests, integration test Docs Changes: n/a Release Notes: n/a part of #1622 fixes #2532 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
modifying the NetworkConfigurationFilter to do asynchronous DNS lookups for non-IP-address proxies. If address resolution fails, the request will be short circuited by sendLocalReply rather than being sent upstream without being proxied. This PR also changes ConnectivityManager to have a pure API and an Impl for testing. Risk Level: low Testing: unit tests, integration test Docs Changes: n/a Release Notes: n/a part of #1622 fixes #2532 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This simplifies the span generic implementation by removing unnecessary indirection **Related Issues/PRs (if applicable)** Follow up on #1582 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hed criteria (path, prefix, future regex).
resolves #1527
DO NOT MERGE
Currently depends on my branch for envoyproxy/data-plane-api#170 so this will need to be merged before this PR. However currently envoy-api latest commit has changes not currently supported by the latest master of this repo.