-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Description
This is a proposal to enable the operation name within the tracing Span to be set to a more appropriate (possibly business relevant) value depending on the path being invoked. For example, currently all REST endpoints on a particular service will be classified with the same operation, making subsequent processing of the span data more complex.
The first part of the proposal is to recommend changing the name of the current operation_name field within the tracing configuration to something more related to its purpose - identifying whether the filter relates to Ingress or Egress. Possibly direction - but open to other suggestions. There could be a deprecation period during which both operation_name and direction could be loaded - but after a suitable time, the operation_name be dropped.
The second part is the configuration of specified operation names associated with paths. Was thinking that a similar structure could be used as with the routes, providing a prefix and associated name. To be even more flexible, it would be good if a regex could also be supported (as an alternative to the prefix), enabling more complex paths (e.g. with path parameters) to be examined - although may have performance implications.
For example,
"filters": [
{
"type": "read",
"name": "http_connection_manager",
"config": {
"tracing": {
"direction": "ingress",
"operations": [
{
"name": "placeOrder",
"method": "POST",
"prefix": "/order"
}
]
},
This proposal may also address #808.