Directly depend on fmtlib for fmt::format#1582
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 1, 2017
Merged
Directly depend on fmtlib for fmt::format#1582mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Member
|
@kmyerson did you already sign the CLA? I'm confused how your previous PRs got in. I don't see you in there now. |
htuch
previously approved these changes
Aug 31, 2017
Member
htuch
left a comment
There was a problem hiding this comment.
I wouldn't be adverse to putting fmtlib in the base envoy_cc_library macro, but don't feel that strongly.
Member
|
Yeah +1 to just putting it in base like we do for spdlog, then we only have to add the include and not edit bazel files... |
Contributor
Author
|
OK, I'll make that change |
mattklein123
approved these changes
Sep 1, 2017
Member
|
@kmyerson looks good. Thank you. FYI in the future once you open a PR please don't rebase it, just merge master and push new commits. This makes it easier to review. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This removes all the duplicated copy-and-pasted code in tracing but having generic interfaces and implementations, and simply instantiating them for each endpoint. This helps reduce the necessary code when adding a new endpoint since now the "recorder" implementation is the only endpoint specific implementation. **Related Issues/PRs (if applicable)** Preparation for #90 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This simplifies the span generic implementation by removing unnecessary indirection **Related Issues/PRs (if applicable)** Follow up on #1582 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-updated build SHA to incorporate spdlog update
-include fmtlib directly in files where spdlog was included in order to use fmt::format, and remove the spdlog include
-edit associated BUILD files to add fmtlib as an external_dep
#975