Support mixed v2/v3 xDS request/responses #12913
Conversation
Signed-off-by: chaoqinli <chaoqinli@google.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Shikugawa
left a comment
There was a problem hiding this comment.
Thank you! Generally LGTM. I'd commented on some of the sections.
Signed-off-by: chaoqinli <chaoqinli@google.com>
|
@adisuissa could you take a first pass? Thanks. |
Signed-off-by: chaoqinli <chaoqinli@google.com>
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for doing this, looks good.
Can you make sure the tests cover cases where getEarlierTypeUrl returns absl::nullopt?
htuch
left a comment
There was a problem hiding this comment.
Looks great, thanks, flushing a few comments.
/wait
adisuissa
left a comment
There was a problem hiding this comment.
Looks good, thanks!
A couple of nits.
Signed-off-by: chaoqinli <chaoqinli@google.com>
|
I have added support for case where grpc_mux watch for v3 type_url but receive v2 type_url resource. |
Signed-off-by: chaoqinli <chaoqinli@google.com>
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo comments on version history, docs and cleaning up the type URL util location.
/wait
Signed-off-by: chaoqinli <chaoqinli@google.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
htuch
left a comment
There was a problem hiding this comment.
Ready to ship once the RST docs suggestions is done, thanks!
/wait
|
@ramaraochavali will be supported until immediately after Q1 2021 release, planning on removing v2 at that point. |
Commit Message: To better support migration from v2 type url to v3 type url, we should be able to support a DiscoveryResponse with a v3 resource to a DiscoveryRequest with v2 resource type. This can be achieved by downgrading the type url when subscriber can't be found.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Support mixed v2/v3 xDS request/responses
[Optional Deprecated:]