remove support for type url downgrade and upgrade conversion#16372
Merged
htuch merged 6 commits intoenvoyproxy:mainfrom May 10, 2021
Merged
remove support for type url downgrade and upgrade conversion#16372htuch merged 6 commits intoenvoyproxy:mainfrom
htuch merged 6 commits intoenvoyproxy:mainfrom
Conversation
added 6 commits
May 5, 2021 22:06
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
yanavlasov
approved these changes
May 7, 2021
Contributor
|
LGTM, @htuch for final approval |
Contributor
Author
|
Do I need to remove this line from current.rst?* xds: added support for mixed v2/v3 discovery response, which enable type url downgrade and upgrade. This feature is disabled by default and is controlled by runtime guard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Remove support for mixed v2/v3 type url introduced by pull request(#12913), address issue(#16015)
Additional Description:
Risk Level:low
Testing:remove testing for mixed version type url support.
Docs Changes:should mention deprecation of this feature in version history
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]