matcher: add PathMatcher and use in routing, jwt and rbac#10010
Merged
lizan merged 2 commits intoenvoyproxy:masterfrom Feb 12, 2020
Merged
matcher: add PathMatcher and use in routing, jwt and rbac#10010lizan merged 2 commits intoenvoyproxy:masterfrom
lizan merged 2 commits intoenvoyproxy:masterfrom
Conversation
Contributor
Author
|
This needs to be back-ported to 1.2 and 1.3 but it seems I cannot add the backport/review label according to https://github.com/envoyproxy/envoy/blob/master/RELEASES.md#backports. @lizan @PiotrSikora , could you also review and approve for the backport, thank you. |
Contributor
|
/backport |
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
719a31b to
200f0cc
Compare
Contributor
Author
|
@lizan @mattklein123 Could you take a look at this one? The only change compared to the other approved PR in the private repo is the last commit that I pushed to fix the integration test. It seems the path normalization is doing something strange here by changing the path from |
mattklein123
approved these changes
Feb 12, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, great work! @PiotrSikora @lizan any further comments?
PiotrSikora
approved these changes
Feb 12, 2020
Contributor
PiotrSikora
left a comment
There was a problem hiding this comment.
Thanks! One small comment.
This was referenced Feb 12, 2020
lizan
approved these changes
Feb 12, 2020
Contributor
|
@yangminzhu could you send PRs with cherry-picks against the stable branches? Thanks! |
Contributor
Author
|
@PiotrSikora Yes, I'm doing it now. |
yangminzhu
added a commit
to yangminzhu/envoy
that referenced
this pull request
Feb 12, 2020
…#10010) Description: Add a new PathMatcher that strips the query and/or fragment string from the ":path" header before matching, use it in route, JWT and RBAC. Risk Level: Low Testing: Added unit tests and integration tests Docs Changes: Updated types.rst for PathMatcher Release Notes: Updated version_history.rst for RBAC API change Signed-off-by: Yangmin Zhu <ymzhu@google.com>
This was referenced Feb 12, 2020
yangminzhu
added a commit
to istio/envoy
that referenced
this pull request
Feb 13, 2020
Cherrypick envoyproxy#10010 Signed-off-by: Yangmin Zhu <ymzhu@google.com>
PiotrSikora
pushed a commit
that referenced
this pull request
Feb 13, 2020
…10037) Description: Add a new PathMatcher that strips the query and/or fragment string from the ":path" header before matching, use it in route, JWT and RBAC. Risk Level: Low Testing: Added unit tests and integration tests Docs Changes: Updated types.rst for PathMatcher Release Notes: Updated version_history.rst for RBAC API change Signed-off-by: Yangmin Zhu <ymzhu@google.com>
PiotrSikora
pushed a commit
that referenced
this pull request
Feb 13, 2020
…rbac (#10010) (#10038) Description: Add a new PathMatcher that strips the query and/or fragment string from the ":path" header before matching, use it in route, JWT and RBAC. Risk Level: Low Testing: Added unit tests and integration tests Docs Changes: Updated types.rst for PathMatcher Release Notes: Updated version_history.rst for RBAC API change Signed-off-by: Yangmin Zhu <ymzhu@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yangmin Zhu ymzhu@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add a new PathMatcher that strips the query and/or fragment string from the ":path" header before matching, use it in route, JWT and RBAC.
Risk Level: Low
Testing: Added unit tests and integration tests
Docs Changes: Updated types.rst for PathMatcher
Release Notes: Updated version_history.rst for RBAC API change
[Optional Fixes #Issue]
[Optional Deprecated:]