Skip to content

[release/v1.12] matcher: add PathMatcher and use in routing, jwt and rbac#10038

Merged
PiotrSikora merged 2 commits intoenvoyproxy:release/v1.12from
yangminzhu:path-matcher-12
Feb 13, 2020
Merged

[release/v1.12] matcher: add PathMatcher and use in routing, jwt and rbac#10038
PiotrSikora merged 2 commits intoenvoyproxy:release/v1.12from
yangminzhu:path-matcher-12

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

Cherry-pick #10010

Signed-off-by: Yangmin Zhu ymzhu@google.com

Description: Add a new PathMatcher that strips the query and/or fragment string from the ":path" header before matching, use it in route, JWT and RBAC.
Risk Level: Low
Testing: Added unit tests and integration tests
Docs Changes: Updated types.rst for PathMatcher
Release Notes: Updated version_history.rst for RBAC API change

Signed-off-by: Yangmin Zhu <ymzhu@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10038 was opened by yangminzhu.

see: more, trace.

@yangminzhu yangminzhu changed the title matcher: add PathMatcher and use in routing, jwt and rbac [release/v1.12] matcher: add PathMatcher and use in routing, jwt and rbac Feb 12, 2020
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
@yangminzhu
Copy link
Copy Markdown
Contributor Author

cc @lizan

@yangminzhu yangminzhu marked this pull request as ready for review February 13, 2020 18:13
@yangminzhu yangminzhu requested a review from lizan as a code owner February 13, 2020 18:13
@PiotrSikora
Copy link
Copy Markdown
Contributor

Skipping @envoyproxy/api-shepherds review (see: #10035). CI is broken on release/v1.12 for unrelated reasons (see: #10027, #10028), so skipping those checks as well.

@yangminzhu
Copy link
Copy Markdown
Contributor Author

Note i pushed an extra commit to fix the unit test. Thanks.

@PiotrSikora PiotrSikora merged commit 92d0094 into envoyproxy:release/v1.12 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants