Skip to content

[release/v.1.13] matcher: add PathMatcher and use in routing, jwt and rbac (#10010)#10037

Merged
PiotrSikora merged 1 commit intoenvoyproxy:release/v1.13from
yangminzhu:path-matcher-13
Feb 13, 2020
Merged

[release/v.1.13] matcher: add PathMatcher and use in routing, jwt and rbac (#10010)#10037
PiotrSikora merged 1 commit intoenvoyproxy:release/v1.13from
yangminzhu:path-matcher-13

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

Cherry-pick #10010

Signed-off-by: Yangmin Zhu ymzhu@google.com

…#10010)

Description: Add a new PathMatcher that strips the query and/or fragment string from the ":path" header before matching, use it in route, JWT and RBAC.
Risk Level: Low
Testing: Added unit tests and integration tests
Docs Changes: Updated types.rst for PathMatcher
Release Notes: Updated version_history.rst for RBAC API change

Signed-off-by: Yangmin Zhu <ymzhu@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10037 was opened by yangminzhu.

see: more, trace.

@yangminzhu yangminzhu marked this pull request as ready for review February 12, 2020 23:41
@yangminzhu
Copy link
Copy Markdown
Contributor Author

The envoy-linux (bazel tsan) failed with //test/common/stats:thread_local_store_test TIMEOUT in 393.5s: https://dev.azure.com/cncf/envoy/_build/results?buildId=30666&view=logs&j=5eb754ee-449a-545e-2b62-07fe525d7cbc&t=1110550d-5f5f-55a9-69fd-d02adf65e59a

@PiotrSikora
Copy link
Copy Markdown
Contributor

/azp run envoy-linux
/azp run envoy-macos

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@PiotrSikora
Copy link
Copy Markdown
Contributor

/azp run envoy-linux

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@PiotrSikora
Copy link
Copy Markdown
Contributor

/azp run envoy-macos

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@zuercher
Copy link
Copy Markdown
Member

/azp run envoy-linux

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@PiotrSikora PiotrSikora merged commit 57eab2b into envoyproxy:release/v1.13 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants