Skip to content

eframe: Improve glow context switching#4814

Merged
emilk merged 2 commits intoemilk:masterfrom
rustbasic:patch78
Jul 11, 2024
Merged

eframe: Improve glow context switching#4814
emilk merged 2 commits intoemilk:masterfrom
rustbasic:patch78

Conversation

@rustbasic
Copy link
Copy Markdown
Contributor

Improved change_gl_context()

Before:
Create a new not_current_glcontext.

After:
If not_current_glcontext exists, apply it. Otherwise, create it.

This will make the program smoother when dragging, etc.

Copy link
Copy Markdown
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Have you tested this with multi-viewports?

@rustbasic
Copy link
Copy Markdown
Contributor Author

Looks good! Have you tested this with multi-viewports?

yes. It does not affect the current content.

@rustbasic rustbasic requested a review from emilk July 11, 2024 08:20
@emilk emilk changed the title Improved change_gl_context() eframe: Improve glow context switching Jul 11, 2024
@emilk emilk added the eframe Relates to epi and eframe label Jul 11, 2024
@emilk emilk merged commit 20359a8 into emilk:master Jul 11, 2024
emilk pushed a commit that referenced this pull request Sep 1, 2024
Fix: The viewport stops working when the program is minimized.   

Fix: Logically, the weird parts have been normalized.
                                                               
**Issue :**
The viewport stops working when the program is minimized.
                         
* Related #3321
* Related #3877
* Related #3985
* Closes #3972
* Closes #4772
* Related #4832 
* Closes #4892
**Solution :**
When `request_redraw()` is performed in Minimized state, the occasional
screen tearing phenomenon has disappeared.
( Probably expected to be the effect of #4814 )
To address the issue of the `Immediate Viewport` not updating in
Minimized state, we can call `request_redraw()`.
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
Improved `change_gl_context()`

**Before:** 
Create a new `not_current_glcontext`. 

**After:**
If `not_current_glcontext` exists, apply it. Otherwise, create it. 

This will make the program smoother when dragging, etc.
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
Fix: The viewport stops working when the program is minimized.   

Fix: Logically, the weird parts have been normalized.
                                                               
**Issue :**
The viewport stops working when the program is minimized.
                         
* Related emilk#3321
* Related emilk#3877
* Related emilk#3985
* Closes emilk#3972
* Closes emilk#4772
* Related emilk#4832 
* Closes emilk#4892
**Solution :**
When `request_redraw()` is performed in Minimized state, the occasional
screen tearing phenomenon has disappeared.
( Probably expected to be the effect of emilk#4814 )
To address the issue of the `Immediate Viewport` not updating in
Minimized state, we can call `request_redraw()`.
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Improved `change_gl_context()`

**Before:** 
Create a new `not_current_glcontext`. 

**After:**
If `not_current_glcontext` exists, apply it. Otherwise, create it. 

This will make the program smoother when dragging, etc.
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Fix: The viewport stops working when the program is minimized.   

Fix: Logically, the weird parts have been normalized.
                                                               
**Issue :**
The viewport stops working when the program is minimized.
                         
* Related emilk#3321
* Related emilk#3877
* Related emilk#3985
* Closes emilk#3972
* Closes emilk#4772
* Related emilk#4832 
* Closes emilk#4892
**Solution :**
When `request_redraw()` is performed in Minimized state, the occasional
screen tearing phenomenon has disappeared.
( Probably expected to be the effect of emilk#4814 )
To address the issue of the `Immediate Viewport` not updating in
Minimized state, we can call `request_redraw()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eframe Relates to epi and eframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants