fix: Wayland general CSD fixes by msizanoen1 · Pull Request #34955 · electron/electron

msizanoen1 · 2022-07-18T15:21:09Z

Description of Change

General Wayland client-side decoration fixes. Check individual commits for more information.

Supersedes #34945, #34948
Fixes #34820, fixes #33161

Checklist

PR description included and stakeholders cc'd (@refi64)
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fix support for Wayland client-side decorations

patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch

zcbenz

I'm good with this change, only with one question: do you know whether Chrome browser has the same problem? If it has, can you try to submit this patch to Chromium as well? If it does not have, do you know why?

msizanoen1 · 2022-07-19T08:06:55Z

I'm good with this change, only with one question: do you know whether Chrome browser has the same problem? If it has, can you try to submit this patch to Chromium as well? If it does not have, do you know why?

This only affects BrowserFrameViewLinuxNative on upstream Chromium, but it doesn't affect any part of the browser itself because the browser currently doesn't use BrowserFrameViewLinuxNative, but draws its own decorations and only uses the toolkit for styling information. Non-browser windows don't use the toolkit at all but uses its own custom (really outdated) decorations.

msizanoen1 · 2022-07-21T10:18:48Z

Rebasing for conflict resolution broke backporting so the branches suitable for backporting are now wayland-general-fixes-19 and wayland-general-fixes-20 for version 19 and 20 respectively.

msizanoen1 · 2022-07-22T16:13:00Z

@zcbenz I changed the fix for unclickable window button in 3d7b7fd, please re-review.

trop · 2022-08-03T08:52:15Z

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

trop · 2022-08-03T13:31:32Z

@msizanoen1 has manually backported this PR to "20-x-y", please check out #35206

trop · 2022-08-03T13:33:38Z

@msizanoen1 has manually backported this PR to "19-x-y", please check out #35207

skoruppa · 2022-08-11T07:11:25Z

Finally working windows decorations on Gnome with Wayland! Thank you :) @msizanoen1, do you know windows controls (maximize, minimize, close) are drawn on the left when my whole system has them on the right? Is that a bug?

msizanoen1 · 2022-08-11T07:16:14Z

This looks like your system is misconfigured. Window decorations always has the correct position on my machine with the window controls position configured using gnome-tweaks.

skoruppa · 2022-08-11T07:23:10Z

Thank you again :) It was configured to the right side in the gnome-tweaks, but after changing to left, and back to right, controls are now on the correct side for the electron apps as well

SilverMight · 2022-10-18T22:43:26Z

Are the windows not fully maximizing issue still a thing? I tried electron 22 and I still get the issue, on GNOME 43.

msizanoen1 · 2022-10-19T10:46:13Z

Are the windows not fully maximizing issue still a thing? I tried electron 22 and I still get the issue, on GNOME 43.

Are you sure you are using the correct Electron binary with the --ozone-platform=wayland --enable-features=WaylandWindowDecorations flags? I can't reproduce it in a GNOME OS Nightly VM using the Electron 22 Alpha binary from GitHub Releases.

SilverMight · 2022-10-20T16:20:38Z

Are the windows not fully maximizing issue still a thing? I tried electron 22 and I still get the issue, on GNOME 43.

Are you sure you are using the correct Electron binary with the --ozone-platform=wayland --enable-features=WaylandWindowDecorations flags? I can't reproduce it in a GNOME OS Nightly VM using the Electron 22 Alpha binary from GitHub Releases.

I figured out the issue - every other theme works but the Dracula GTK theme I'm using, for some reason, so that must be a problem there. Thanks regardless!

* fix: broken wayland window decorations due to botched chromium update The `GetTitlebarBounds().height()` is obviously intended to be placed in the `top` parameter, which used to be the second one before upstream removed multi-parameter `gfx::Rect::Inset`, but it's the first parameter for `gfx::Insets::TLBR`, which was intended to replace the removed `Inset` function. However, whoever updated Chromium kept the parameter unchanged, causing the title bar height to be passed to the `left` parameter, causing the window title bar to be unclickable. * fix: wayland window top bar buttons unclickable Use NonClientFrameView::TargetForRect for the ClientFrameViewLinux implementation because the default inherited from FramelessView blocks any non-HTCLIENT events. * fix: add maximized parameter to LinuxUI::GetWindowFrameProvider * fix: pass frame_->IsMaximized() to GetWindowFrameProvider This ensures that the toolkit renders the window decorations in maximized mode while the window is maximized to ensure that there is no empty space around the window.

electron-cation bot added the new-pr 🌱 PR opened recently label Jul 18, 2022

ckerr mentioned this pull request Jul 18, 2022

fix: broken wayland window decorations due to botched chromium update #34945

Closed

3 tasks

fontivan mentioned this pull request Jul 18, 2022

Wayland rendering backend not working SpacingBat3/WebCord#159

Closed

5 tasks

msizanoen1 force-pushed the wayland-general-fixes branch from 7aa2e63 to 993dfbb Compare July 19, 2022 02:41

msizanoen1 marked this pull request as ready for review July 19, 2022 02:41

msizanoen1 requested review from a team as code owners July 19, 2022 02:41

msizanoen1 force-pushed the wayland-general-fixes branch from 993dfbb to ae87928 Compare July 19, 2022 02:45

msizanoen1 marked this pull request as draft July 19, 2022 02:48

msizanoen1 marked this pull request as ready for review July 19, 2022 03:18

msizanoen1 changed the title ~~fix: Wayland general fixes~~ fix: Wayland general CSD fixes Jul 19, 2022

zcbenz reviewed Jul 19, 2022

View reviewed changes

patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch Show resolved Hide resolved

zcbenz reviewed Jul 19, 2022

View reviewed changes

zcbenz added semver/patch backwards-compatible bug fixes target/19-x-y labels Jul 19, 2022

zcbenz approved these changes Jul 19, 2022

View reviewed changes

electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 20, 2022

msizanoen1 force-pushed the wayland-general-fixes branch 2 times, most recently from 9713e08 to 54e6ddc Compare July 20, 2022 15:28

GrantMoyer mentioned this pull request Jul 20, 2022

No header bar when launching Logseq with native Wayland flags logseq/logseq#5010

Closed

msizanoen1 force-pushed the wayland-general-fixes branch from 54e6ddc to e20536f Compare July 20, 2022 23:31

msizanoen1 force-pushed the wayland-general-fixes branch 4 times, most recently from 0e2309a to e273cc6 Compare July 22, 2022 16:11

msizanoen1 requested a review from zcbenz July 22, 2022 16:12

trop bot added needs-manual-bp/19-x-y and removed target/20-x-y labels Aug 3, 2022

msizanoen1 deleted the wayland-general-fixes branch August 3, 2022 08:52

msizanoen1 mentioned this pull request Aug 3, 2022

fix: Wayland general CSD fixes #35206

Merged

trop bot added in-flight/20-x-y and removed needs-manual-bp/20-x-y labels Aug 3, 2022

msizanoen1 mentioned this pull request Aug 3, 2022

fix: Wayland general CSD fixes #35207

Merged

trop bot added in-flight/19-x-y and removed needs-manual-bp/19-x-y labels Aug 3, 2022

satmandu mentioned this pull request Aug 11, 2022

On Wayland Decoration is missing signalapp/Signal-Desktop#5869

Closed

2 tasks

r2binx mentioned this pull request Sep 12, 2022

Enable WaylandWindowDecorations feature when on Wayland. flathub/com.slack.Slack#162

Merged

commit-lint bot mentioned this pull request Oct 12, 2022

[pull] main from electron:main Blaquez-home/electron#3

Open

SilverMight mentioned this pull request Oct 22, 2022

[BUG] Padding/border around fullscreen Electron on Wayland window with WaylandWindowDecorations enabled dracula/gtk#219

Open

sarim mentioned this pull request Nov 13, 2022

--ozone-platform-hint flag not working shiftkey/desktop#664

Closed

Conversation

msizanoen1 commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

Uh oh!

zcbenz left a comment

Choose a reason for hiding this comment

Uh oh!

msizanoen1 commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msizanoen1 commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msizanoen1 commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trop bot commented Aug 3, 2022

Uh oh!

trop bot commented Aug 3, 2022

Uh oh!

trop bot commented Aug 3, 2022

Uh oh!

skoruppa commented Aug 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msizanoen1 commented Aug 11, 2022

Uh oh!

skoruppa commented Aug 11, 2022

Uh oh!

SilverMight commented Oct 18, 2022

Uh oh!

msizanoen1 commented Oct 19, 2022

Uh oh!

SilverMight commented Oct 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

msizanoen1 commented Jul 18, 2022 •

edited

Loading

msizanoen1 commented Jul 19, 2022 •

edited

Loading

msizanoen1 commented Jul 21, 2022 •

edited

Loading

msizanoen1 commented Jul 22, 2022 •

edited

Loading

skoruppa commented Aug 11, 2022 •

edited

Loading