fix: don't set window decoration insets when maximized#34948
Closed
msizanoen1 wants to merge 1 commit intoelectron:mainfrom
Closed
fix: don't set window decoration insets when maximized#34948msizanoen1 wants to merge 1 commit intoelectron:mainfrom
msizanoen1 wants to merge 1 commit intoelectron:mainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Don't set window decoration insets while maximized on Linux/Wayland. This causes the window to still have the window shadow padding around it while maximized.
Upstream code reference: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/frame/browser_desktop_window_tree_host_linux.cc;l=171-175;drc=c3d2363d9442969358bc902a14fe68225991e0ab
Fixes #33161
Checklist
npm testpassesRelease Notes
Notes: Fixed empty space around maximized window on Wayland