fix: broken wayland window decorations due to botched chromium update#34945
Closed
msizanoen1 wants to merge 1 commit intoelectron:mainfrom
Closed
Conversation
The `GetTitlebarBounds().height()` is obviously intended to be placed in the `top` parameter, which used to be the second one before upstream removed multi-parameter `gfx::Rect::Inset`, but it's the first parameter for `gfx::Insets::TLBR`, which was intended to replace the removed `Inset` function. However, whoever updated Chromium kept the parameter unchanged, causing the title bar height to be passed to the `left` parameter, causing the window title bar to be unclickable.
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
refi64
reviewed
Jul 18, 2022
Contributor
refi64
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
2 tasks
ckerr
approved these changes
Jul 18, 2022
Member
|
This is a nice fix and is approved, but I'm going to close it since @msizanoen1 has marked it as superseded by #34955 and the PR there does include this fix. So let's continue discussion over in that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The
GetTitlebarBounds().height()expression is obviously intended to be placed in thetopparameter, which used to be the second one before upstream removed multi-parametergfx::Rect::Inset, but it's the first parameter forgfx::Insets::TLBR, which was intended to replace the removedInsetfunction. However, whoever updated Chromium kept the parameter ordering unchanged, causing the title bar height to be passed to theleftparameter, causing the window title bar to be unclickable.Fixes partially #34820
Checklist
npm testpassesRelease Notes
Notes: Fix mangled Wayland client-side decorations