Backport fixes to enable feature flag#11970
Closed
andsel wants to merge 3 commits intoelastic:7.xfrom
Closed
Conversation
Some QA tests reads the FEATURE_FLAG environment variable, for example to test PQ functionality. This PR passthrough the environement variable inside the Docker instance.
…LAG is enabled Updated log4j definitions used when FEATURE_FLAG=persistent_queue is used. Closes elastic#11924
…s for _node/stats Avoid to reassing the subdocument for queue metrics preferring a merge With PR elastic#10576 the PluginsStats.report(stats) overwrites the subsection related to queue instead of merge with newly created entries.
robbavey
approved these changes
Jun 5, 2020
Member
robbavey
left a comment
There was a problem hiding this comment.
LGTM, but can we make sure these are separate commits in the codebase? They address different concerns, making functional changes to the code, changes to test fixtures, and correcting visibility of a flag in CI
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 5, 2020
Some QA tests reads the FEATURE_FLAG environment variable, for example to test PQ functionality. This PR passthrough the environement variable inside the Docker instance. Fixes #11970
This was referenced Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cumulative backport to
7.xfor: